WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95265
Added ANDROID_GDBSERVER definition for Ant
https://bugs.webkit.org/show_bug.cgi?id=95265
Summary
Added ANDROID_GDBSERVER definition for Ant
michaelbai
Reported
2012-08-28 16:54:42 PDT
Added ANDROID_GDBSERVER definition, it will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN is only used for finding the gdbserver.
Attachments
Patch
(3.81 KB, patch)
2012-08-28 17:11 PDT
,
michaelbai
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
michaelbai
Comment 1
2012-08-28 17:11:07 PDT
Created
attachment 161097
[details]
Patch
Peter Beverloo (cr-android ews)
Comment 2
2012-08-28 19:22:46 PDT
Comment on
attachment 161097
[details]
Patch
Attachment 161097
[details]
did not pass cr-android-ews (chromium-android): Output:
http://queues.webkit.org/results/13683005
Peter Beverloo
Comment 3
2012-08-29 03:16:24 PDT
Patch LGTM, but we can't land this yet. In the future you can consider using the "[Chromium]" prefix to bug titles for changes which only touch Chromium-specific code. There unfortunately is a three-way process to introduce new gyp variables, because of a circular dependency between Chromium and WebKit. The first step would be to introduce the variable in envsetup_functions.sh and add it to the GYP_DEFINES section. Then, after Chromium rolls into WebKit (which will happen roughly once per two days), this patch has to land. It should be fine to go in as it is. The last step is to wait until WebKit rolls into Chromium (which happens several times per day), after which you can start using the new variable.
michaelbai
Comment 4
2012-08-31 09:33:02 PDT
Hi Peter, The chromium side CL was landed, Would you like help to commit this?
Peter Beverloo
Comment 5
2012-08-31 09:41:41 PDT
I'll land this on Monday, as the relevant Chromium revision has to roll into WebKit as well. Adam/Nate, could you review this please? It looks good to me :-).
Adam Barth
Comment 6
2012-09-01 00:43:41 PDT
Comment on
attachment 161097
[details]
Patch Sure. rs=me
Peter Beverloo
Comment 7
2012-09-03 11:13:43 PDT
Comment on
attachment 161097
[details]
Patch Thanks, Adam! This should work fine now.
WebKit Review Bot
Comment 8
2012-09-03 11:36:42 PDT
Comment on
attachment 161097
[details]
Patch Clearing flags on attachment: 161097 Committed
r127430
: <
http://trac.webkit.org/changeset/127430
>
WebKit Review Bot
Comment 9
2012-09-03 11:36:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug