Bug 95264 – [EFL] Move several files to remove webkit1 dependency from WebCore.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

Below files are WebKit1 specfic files so that they should be in WebKit/efl.
- platform/efl/ColorChooserEfl.cpp
- platform/efl/PopupMenuEfl.cpp
- platform/efl/SearchPopupMenuEfl.cpp

[Ryuan Choi]

Created attachment 161093 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 161093 [details]
Patch

Not having a dependency on WebCoreSupport in WebCore is definitely a plus. Do you know if these files are normally in the WebKit layer for other ports as well?

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 161093 [details])
> Not having a dependency on WebCoreSupport in WebCore is definitely a plus. Do you know if these files are normally in the WebKit layer for other ports as well?

It depends on port.
For Qt, they are in WebCoreSupport.
But for gtk, they are in WebCore/platform.

In case of Gtk port, they don't have dependency on WebCoreSupport.

[Early Warning System Bot]

Comment on attachment 161093 [details]
Patch

Attachment 161093 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13690002

[Ryuan Choi]

Created attachment 161117 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 161117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161117&action=review

LGTM

> Source/WebKit/efl/WebCoreSupport/PopupMenuEfl.h:36
> +    PopupMenuEfl(PopupMenuClient*);

Could you please add *explicit* keyword in new bug ?

> Source/WebKit/efl/WebCoreSupport/SearchPopupMenuEfl.h:31
> +    SearchPopupMenuEfl(PopupMenuClient*);

ditto.

[WebKit Review Bot]

Comment on attachment 161117 [details]
Patch

Clearing flags on attachment: 161117

Committed r126971: <http://trac.webkit.org/changeset/126971>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.