Bug 95263 - ondisplay event handlers are not called
Summary: ondisplay event handlers are not called
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.8
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on: 95638
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-28 16:40 PDT by Jon Lee
Modified: 2012-09-01 00:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2012-08-31 13:55 PDT, Jon Lee 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2012-08-28 16:40:05 PDT 
When a notification is shown by the platform, the onshow event handler (which is the standard event) gets called, but not the ondisplay event handler (which is the legacy event).

The proper fix here, probably, would be to conflate the two, rather than treating the two separately.
Comment 1 Radar WebKit Bug Importer 2012-08-28 16:40:20 PDT 
<rdar://problem/12193359>
Comment 2 Jon Lee 2012-08-31 13:55:25 PDT 
Created attachment 161765 [details]
Patch
Comment 3 Jon Lee 2012-08-31 14:26:17 PDT 
Committed r127321: <http://trac.webkit.org/changeset/127321>
Comment 4 Csaba Osztrogonác 2012-09-01 00:37:22 PDT 
(In reply to comment #3)
> Committed r127321: <http://trac.webkit.org/changeset/127321>

It broke 3 tests on Qt. Could you check it, please?
Here is the bug report: https://bugs.webkit.org/show_bug.cgi?id=95638