Bug 95259 - Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
Summary: Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: nbhargava
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 16:20 PDT by nbhargava
Modified: 2012-08-31 12:11 PDT (History)
13 users (show)

See Also:

Attachments
Patch (30.78 KB, patch)
2012-08-28 16:23 PDT, nbhargava 		no flags Details | Formatted Diff | Diff
Patch (30.81 KB, patch)
2012-08-28 16:33 PDT, nbhargava 		no flags Details | Formatted Diff | Diff
Patch (30.83 KB, patch)
2012-08-28 16:46 PDT, nbhargava 		no flags Details | Formatted Diff | Diff
Patch (31.56 KB, patch)
2012-08-29 13:14 PDT, nbhargava 		no flags Details | Formatted Diff | Diff
Patch (30.77 KB, patch)
2012-08-29 16:13 PDT, nbhargava 		no flags Details | Formatted Diff | Diff
Patch for landing (28.88 KB, patch)
2012-08-30 16:25 PDT, nbhargava 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nbhargava 2012-08-28 16:20:37 PDT 
Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
Comment 1 nbhargava 2012-08-28 16:23:13 PDT 
Created attachment 161083 [details]
Patch
Comment 2 nbhargava 2012-08-28 16:26:06 PDT 
Comment on attachment 161083 [details]
Patch

This patch removes several #includes from across the project that are unnecessary or over-inclusive. The focus is primarily on Node.h, Document.h, Element.h, and RenderObject.h though some other includes may be added or removed to make sure it still compiles.

There is a slight compile-time performance boost but the main purpose of this was to remove some excess and make further compile-time analysis easier.
Comment 3 nbhargava 2012-08-28 16:33:09 PDT 
Created attachment 161087 [details]
Patch
Comment 4 nbhargava 2012-08-28 16:46:58 PDT 
Created attachment 161089 [details]
Patch
Comment 5 kov's GTK+ EWS bot 2012-08-28 17:09:04 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13663487
Comment 6 Gyuyoung Kim 2012-08-28 17:13:41 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13665445
Comment 7 Build Bot 2012-08-28 17:24:53 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13659540
Comment 8 Early Warning System Bot 2012-08-28 17:51:12 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13660513
Comment 9 Early Warning System Bot 2012-08-28 18:02:57 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13662467
Comment 10 WebKit Review Bot 2012-08-28 18:18:56 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13651590
Comment 11 Peter Beverloo (cr-android ews) 2012-08-28 18:21:32 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13658559
Comment 12 Build Bot 2012-08-28 20:13:35 PDT 
Comment on attachment 161089 [details]
Patch

Attachment 161089 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13685019
Comment 13 nbhargava 2012-08-29 13:14:05 PDT 
Created attachment 161294 [details]
Patch
Comment 14 Build Bot 2012-08-29 13:34:34 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13694357
Comment 15 kov's GTK+ EWS bot 2012-08-29 13:48:54 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13687346
Comment 16 Early Warning System Bot 2012-08-29 14:14:02 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13687353
Comment 17 Build Bot 2012-08-29 14:18:59 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13694369
Comment 18 Early Warning System Bot 2012-08-29 14:34:50 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13689401
Comment 19 Gyuyoung Kim 2012-08-29 14:56:19 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13687372
Comment 20 Peter Beverloo (cr-android ews) 2012-08-29 15:09:19 PDT 
Comment on attachment 161294 [details]
Patch

Attachment 161294 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13693419
Comment 21 nbhargava 2012-08-29 16:13:43 PDT 
Created attachment 161349 [details]
Patch
Comment 22 Gyuyoung Kim 2012-08-29 18:40:19 PDT 
Comment on attachment 161349 [details]
Patch

Attachment 161349 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13680499
Comment 23 Gyuyoung Kim 2012-08-29 18:55:21 PDT 
Comment on attachment 161349 [details]
Patch

Attachment 161349 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13688532
Comment 24 nbhargava 2012-08-30 16:25:31 PDT 
Created attachment 161580 [details]
Patch for landing
Comment 25 WebKit Review Bot 2012-08-31 12:11:10 PDT 
Comment on attachment 161580 [details]
Patch for landing

Clearing flags on attachment: 161580

Committed r127300: <http://trac.webkit.org/changeset/127300>
Comment 26 WebKit Review Bot 2012-08-31 12:11:15 PDT 
All reviewed patches have been landed.  Closing bug.