Bug 95257 - [chromium] Remove HUD layer when rootLayer is set to null
Summary: [chromium] Remove HUD layer when rootLayer is set to null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 16:04 PDT by Dana Jansens
Modified: 2012-08-29 16:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.17 KB, patch)
2012-08-28 16:10 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (12.62 KB, patch)
2012-08-29 08:30 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-08-28 16:04:54 PDT 
[chromium] Remove HUD layer when rootLayer is set to null
Comment 1 Dana Jansens 2012-08-28 16:10:38 PDT 
Created attachment 161082 [details]
Patch
Comment 2 James Robinson 2012-08-28 16:15:43 PDT 
Comment on attachment 161082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161082&action=review

> Source/WebKit/chromium/ChangeLog:10
> +        (WTF):

can you remove these WTF's from the ChangeLog? the changelog generator script is stupid about anonymous namespaces

> Source/WebKit/chromium/tests/CCHeadsUpDisplayTest.cpp:36
> +using namespace WebCore;
> +using namespace WebKit;
> +using namespace WebKitTests;
> +using namespace WTF;

this is a bit excessive - can you trim it down so we know what we're actually depending on? i'm pretty sure you don't need using namespace WTF ever - if you #include the appropriate <wtf/...> header it puts the relevant things (like OwnPtr) in the global namespace for you

> Source/WebKit/chromium/tests/CCThreadedTest.h:34
> +#include <public/WebThread.h>

this isn't used, is it? kill if not
Comment 3 Dana Jansens 2012-08-29 08:01:38 PDT 
Comment on attachment 161082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161082&action=review

>> Source/WebKit/chromium/ChangeLog:10
>> +        (WTF):
> 
> can you remove these WTF's from the ChangeLog? the changelog generator script is stupid about anonymous namespaces

oh! k

>> Source/WebKit/chromium/tests/CCHeadsUpDisplayTest.cpp:36
>> +using namespace WTF;
> 
> this is a bit excessive - can you trim it down so we know what we're actually depending on? i'm pretty sure you don't need using namespace WTF ever - if you #include the appropriate <wtf/...> header it puts the relevant things (like OwnPtr) in the global namespace for you

yes, ill trim the list in CCLTHTest.cpp too.

>> Source/WebKit/chromium/tests/CCThreadedTest.h:34
>> +#include <public/WebThread.h>
> 
> this isn't used, is it? kill if not

it is, we have an OwnPtr of one here somewhere.
Comment 4 Dana Jansens 2012-08-29 08:30:51 PDT 
Created attachment 161234 [details]
Patch
Comment 5 Dana Jansens 2012-08-29 08:32:02 PDT 
I spent some time cleaning up the namespace and header includes among CCThreadedTest/CCLayerTreeHostTest/CCHeadsUpDisplayTest, there was some duplication and things that should have been moved to CCThreadedTest but hadn't been.
Comment 6 WebKit Review Bot 2012-08-29 16:20:00 PDT 
Comment on attachment 161234 [details]
Patch

Clearing flags on attachment: 161234

Committed r127064: <http://trac.webkit.org/changeset/127064>
Comment 7 WebKit Review Bot 2012-08-29 16:20:03 PDT 
All reviewed patches have been landed.  Closing bug.