Bug 95257 – [chromium] Remove HUD layer when rootLayer is set to null

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Remove HUD layer when rootLayer is set to null

[Dana Jansens]

Created attachment 161082 [details]
Patch

[James Robinson]

Comment on attachment 161082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161082&action=review

> Source/WebKit/chromium/ChangeLog:10
> +        (WTF):

can you remove these WTF's from the ChangeLog? the changelog generator script is stupid about anonymous namespaces

> Source/WebKit/chromium/tests/CCHeadsUpDisplayTest.cpp:36
> +using namespace WebCore;
> +using namespace WebKit;
> +using namespace WebKitTests;
> +using namespace WTF;

this is a bit excessive - can you trim it down so we know what we're actually depending on? i'm pretty sure you don't need using namespace WTF ever - if you #include the appropriate <wtf/...> header it puts the relevant things (like OwnPtr) in the global namespace for you

> Source/WebKit/chromium/tests/CCThreadedTest.h:34
> +#include <public/WebThread.h>

this isn't used, is it? kill if not

[Dana Jansens]

Comment on attachment 161082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161082&action=review

>> Source/WebKit/chromium/ChangeLog:10
>> +        (WTF):
> 
> can you remove these WTF's from the ChangeLog? the changelog generator script is stupid about anonymous namespaces

oh! k

>> Source/WebKit/chromium/tests/CCHeadsUpDisplayTest.cpp:36
>> +using namespace WTF;
> 
> this is a bit excessive - can you trim it down so we know what we're actually depending on? i'm pretty sure you don't need using namespace WTF ever - if you #include the appropriate <wtf/...> header it puts the relevant things (like OwnPtr) in the global namespace for you

yes, ill trim the list in CCLTHTest.cpp too.

>> Source/WebKit/chromium/tests/CCThreadedTest.h:34
>> +#include <public/WebThread.h>
> 
> this isn't used, is it? kill if not

it is, we have an OwnPtr of one here somewhere.

[Dana Jansens]

Created attachment 161234 [details]
Patch

[Dana Jansens]

I spent some time cleaning up the namespace and header includes among CCThreadedTest/CCLayerTreeHostTest/CCHeadsUpDisplayTest, there was some duplication and things that should have been moved to CCThreadedTest but hadn't been.

[WebKit Review Bot]

Comment on attachment 161234 [details]
Patch

Clearing flags on attachment: 161234

Committed r127064: <http://trac.webkit.org/changeset/127064>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.