RESOLVED FIXED95251
[New Multicolumn] Get column contents painting properly. 
https://bugs.webkit.org/show_bug.cgi?id=95251
Summary [New Multicolumn] Get column contents painting properly.
Dave Hyatt
Reported 2012-08-28 15:03:18 PDT
Implement paintColumnContents for the new multicolumn implementation, so that columns finally render something besides rules. ;)
Attachments
Patch (14.72 KB, patch)
2012-08-28 15:11 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2012-08-28 15:11:38 PDT
Created attachment 161070 [details] Patch
WebKit Review Bot
Comment 2 2012-08-28 15:14:13 PDT
Attachment 161070 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderMultiColumnSet.cpp:32: Use 'using namespace std;' instead of 'using std::min;'. [build/using_std] [4] Source/WebCore/rendering/RenderMultiColumnSet.cpp:33: Use 'using namespace std;' instead of 'using std::max;'. [build/using_std] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2012-08-28 15:14:53 PDT
Comment on attachment 161070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161070&action=review > Source/WebCore/rendering/RenderMultiColumnSet.cpp:33 > +using std::min; > +using std::max; The cool kids are now just using std::max at the call sites, I'm told.
Dave Hyatt
Comment 4 2012-08-29 10:08:56 PDT
Landed in r127008.
Note You need to log in before you can comment on or make changes to this bug.