WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
95241
Close bugs when cowboy landing.
https://bugs.webkit.org/show_bug.cgi?id=95241
Summary
Close bugs when cowboy landing.
Philip Rogers
Reported
2012-08-28 13:52:32 PDT
Small feature request: if there's a bug in the ChangeLog we could close it when cowboy landing.
Attachments
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2012-08-28 14:08:50 PDT
Makes sense to me. Should be easy to do.
Adam Barth
Comment 2
2012-08-28 15:44:04 PDT
@pdr: Compare: LandCowboy
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/download.py#L114
Land
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/download.py#L87
Notice that both execute the step CloseBugForLandDiff. The difference is that Land's _prepare_state function grabs the bug_id_for_this_commit and store it in bug_id and LandCowboy's _prepare_state does not. Note: Unlike most of this code, there are no tests for LandCowboy because cowboys don't write tests. :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug