Bug 95232 - [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
Summary: [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.8
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on: 79492 95249 95505
Blocks: 77969
  Show dependency tree / graph
 
Reported: 2012-08-28 12:37 PDT by Jon Lee
Modified: 2012-08-30 15:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.75 KB, patch)
2012-08-29 14:00 PDT, Jon Lee 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2012-08-28 12:37:16 PDT 
With this flag set, test output will include events that mimic what would happen on the platform level, such as a user clicking on a notification, or the platform showing a notification.
Comment 1 Radar WebKit Bug Importer 2012-08-28 12:37:32 PDT 
<rdar://problem/12190776>
Comment 2 Jon Lee 2012-08-29 14:00:21 PDT 
Created attachment 161308 [details]
Patch
Comment 3 Alexey Proskuryakov 2012-08-30 11:35:52 PDT 
Comment on attachment 161308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review

> Tools/DumpRenderTree/mac/UIDelegate.mm:294
> +    printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin stringValue] UTF8String]);

Should this be guarded by gTestRunner->dumpWebNotificationCallbacks?
Comment 4 Jon Lee 2012-08-30 11:36:29 PDT 
Comment on attachment 161308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161308&action=review

>> Tools/DumpRenderTree/mac/UIDelegate.mm:294
>> +    printf("REQUESTED WEB NOTIFICATION PERMISSION FOR %s\n", [[origin stringValue] UTF8String]);
> 
> Should this be guarded by gTestRunner->dumpWebNotificationCallbacks?

Yes! Thank you.
Comment 5 Jon Lee 2012-08-30 12:45:49 PDT 
Committed r127171: <http://trac.webkit.org/changeset/127171>
Comment 6 WebKit Review Bot 2012-08-30 15:01:26 PDT 
Re-opened since this is blocked by 95505
Comment 7 Jon Lee 2012-08-30 15:10:57 PDT 
ap did not feel that this additional output added value for tests, and that the javascript events should suffice. rolling out in bug 95505.