Bug 95222 – webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Julien Chaffraix]

Created attachment 161023 [details]
Repro patch against r126890

Trying to do the rebaselining after r126683, I am consistently hitting this issue. Attached is a rebaseline patch against r126890 that shows the issue.

Steps to reproduce:
* Apply attached patch.
* webkit-patch rebaseline-expectations

You should see the issue. I have experienced it in an SVN and GIT checkout.

[Julien Chaffraix]

Created attachment 161024 [details]
Bad diff - notice the Qt TestExpectation changes

[Dirk Pranke]

I've reproduced the problem and am working on it.

[Dirk Pranke]

Okay, Ojan was right. This code isn't well tested :).

I've stumbled across several bugs and inefficiencies while debugging this, but the bug that is causing this particular problem is relatively isolated so I'll just post a patch for this and save the other issues for later. Patch coming up shortly ...

[Dirk Pranke]

Created attachment 161100 [details]
Patch

[Adam Barth]

Comment on attachment 161100 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 161100 [details]
Patch

Rejecting attachment 161100 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 161100 [details]
Patch

Rejecting attachment 161100 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Adam Barth]

Comment on attachment 161100 [details]
Patch

Sorry, the bots a freaking out because of an AppEngine issue.  Let's try this again.  If this errors out, we might need to wait for AppEngine to be less insane.

[WebKit Review Bot]

Comment on attachment 161100 [details]
Patch

Rejecting attachment 161100 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Dirk Pranke]

Committed r127058: <http://trac.webkit.org/changeset/127058>