WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
Bug 95219
Cache and share parsed imported stylesheets
https://bugs.webkit.org/show_bug.cgi?id=95219
Summary
Cache and share parsed imported stylesheets
Antti Koivisto
Reported
2012-08-28 11:07:01 PDT
We currently cache and share parsed data structures of stylesheets loaded with <link>. We should do the same with stylesheets loaded using @import rules as they are also fairly common.
Attachments
patch
(7.16 KB, patch)
2012-08-28 11:18 PDT
,
Antti Koivisto
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2012-08-28 11:18:19 PDT
Created
attachment 161018
[details]
patch Mutation-of-shared-import case could probably use a test case. Not sure if that is covered.
Andreas Kling
Comment 2
2012-08-28 11:22:07 PDT
Comment on
attachment 161018
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=161018&action=review
Awesome. r=me
> Source/WebCore/css/StyleRuleImport.cpp:62 > -void StyleRuleImport::setCSSStyleSheet(const String& url, const KURL& baseURL, const String& charset, const CachedCSSStyleSheet*) > +void StyleRuleImport::setCSSStyleSheet(const String& url, const KURL& baseURL, const String& charset, const CachedCSSStyleSheet* )
ORLY?
Antti Koivisto
Comment 3
2012-08-30 04:07:36 PDT
http://trac.webkit.org/changeset/127123
Turned out we have test coverage for import mutations too.
Alexey Proskuryakov
Comment 4
2012-09-14 12:06:12 PDT
Rolled out in <
http://trac.webkit.org/changeset/128637
>, because this depended on an earlier patch that had to be rolled out.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug