RESOLVED FIXED95213
[New Multicolumn] Rename some RenderFlowThread methods and add some arguments to functions 
https://bugs.webkit.org/show_bug.cgi?id=95213
Summary [New Multicolumn] Rename some RenderFlowThread methods and add some arguments...
Dave Hyatt
Reported 2012-08-28 09:51:33 PDT
Rename paintIntoRegion and hitTestRegion so that they can take a flow thread portion that isn't necessarily tied to the flow thread portion of the entire region. In order to work with region sets like the new multicolumn layout, these functions have to be able to paint a portion of a portion.
Attachments
Patch (25.15 KB, patch)
2012-08-28 09:55 PDT, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2012-08-28 09:55:50 PDT
Created attachment 161002 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-08-28 10:05:57 PDT
Comment on attachment 161002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161002&action=review > Source/WebCore/ChangeLog:9 > + Rename regionRect()/setRegionRect()/m_regionRect on RenderRegion to be flowThreadPortionRect instead. flowThreadPortion is a bit of a mouthful, but I can't think of anything better.
Dave Hyatt
Comment 3 2012-08-28 10:59:08 PDT
Landed in r126895.
Note You need to log in before you can comment on or make changes to this bug.