ASSIGNED 95203
Dotted borders not drawn with rounded dots 
https://bugs.webkit.org/show_bug.cgi?id=95203
Summary Dotted borders not drawn with rounded dots
Martin Leutelt
Reported 2012-08-28 07:54:41 PDT
As per CSS spec here http://www.w3.org/TR/css3-background/#border-style dotted borders should be drawn with rounded dots. Websites for testing: http://www.w3schools.com/cssref/tryit.asp?filename=trycss_border-style http://dev.harnos.at/webkit/border-bug/
Attachments
Proposed patch (7.75 KB, patch)
2012-08-28 08:18 PDT, Martin Leutelt 		no flags
DetailsFormatted DiffDiff
Patch with updated expected results (deleted)
2012-08-31 05:22 PDT, Martin Leutelt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Leutelt
Comment 1 2012-08-28 08:18:31 PDT
Created attachment 160987 [details] Proposed patch
Martin Robinson
Comment 2 2012-08-30 10:05:57 PDT
I think when evaluating this patch it would be very useful to see how it affects pixel results. Many pixel results are out of date so here's my suggestion: 1. Run pixel tests and update all results. 2. Run pixel results again and detect which results change. 3. Attach only results that changed to your patch. Be sure to run tests with the jhbuild environment by running $ Tools/Scripts/update-webkitgtk-libs before you build.
Martin Leutelt
Comment 3 2012-08-31 05:22:02 PDT
Created attachment 161671 [details] Patch with updated expected results
Martin Robinson
Comment 4 2012-09-03 10:22:25 PDT
A couple things worry me about this patch: 1. It doesn't look like any other WebKit browsers that I tested (Chromium and Safari on Mac) and Firefox use rounded dots. 2. This patch changes the behavior for content not rendered according to the CSS spec as well.
Martin Leutelt
Comment 5 2012-09-04 00:04:46 PDT
Thanks for your comments. on 1: For Chromium I already submitted a patch (https://bugs.webkit.org/show_bug.cgi?id=94917). I'm waiting on some comments there. The patch for the Qt port has already been landed (https://bugs.webkit.org/show_bug.cgi?id=92383). I can't build the mac port so I won't be able to submit a patch for that. To track all those patches I guess we should use this one (https://bugs.webkit.org/show_bug.cgi?id=25737). Firefox uses rounded dots but also not according to the css spec. on 2: Could you give me some example for a case where the patch would lead to some unexpected outcome?
Anders Carlsson
Comment 6 2014-02-05 11:12:44 PST
Comment on attachment 161671 [details] Patch with updated expected results Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Myles C. Maxfield
Comment 7 2016-06-20 16:20:00 PDT
<rdar://problem/3175114>
Simon Fraser (smfr)
Comment 8 2024-08-05 18:45:07 PDT
I don't think this is particularly easy
Note You need to log in before you can comment on or make changes to this bug.