Bug 95199 - [EFL] WebKit EFL updates view on HTTP 204 response
Summary: [EFL] WebKit EFL updates view on HTTP 204 response
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-28 07:25 PDT by Chris Dumez
Modified: 2012-08-28 08:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2012-08-28 07:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.10 KB, patch)
2012-08-28 07:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-08-28 07:25:42 PDT 
WebKitEFL currently updates the view on HTTP 204 response (No content). Such response should be ignored.
This causes the following test case to fail:
  http/tests/navigation/response204.html
Comment 1 Chris Dumez 2012-08-28 07:29:52 PDT 
Created attachment 160973 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-28 07:46:39 PDT 
Comment on attachment 160973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160973&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client.cpp:63
> +    if (resourceResponse.httpStatusCode() == 204) {

Using #include "HTTPStatusCodes.h"  would be better
Comment 3 Chris Dumez 2012-08-28 07:55:01 PDT 
Created attachment 160981 [details]
Patch

Take Kenneth's feedback into consideration.
Comment 4 WebKit Review Bot 2012-08-28 08:46:31 PDT 
Comment on attachment 160981 [details]
Patch

Clearing flags on attachment: 160981

Committed r126884: <http://trac.webkit.org/changeset/126884>
Comment 5 WebKit Review Bot 2012-08-28 08:46:35 PDT 
All reviewed patches have been landed.  Closing bug.