Bug 95183 – [Qt] New inspector/profiler/webgl-profiler-api-changes.html times out

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

This test introduced in https://trac.webkit.org/changeset/126856,
but fails on Qt with notifyDone timeout:


--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/profiler/webgl-profiler-api-changes-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/profiler/webgl-profiler-api-changes-actual.txt 
@@ -1,67 +1,11 @@
+CONSOLE MESSAGE: line 155: TypeError: 'null' is not an object (evaluating 'gl.createTexture')
+FAIL: Timed out waiting for notifyDone to be called
 Test to catch WebGL API changes. If this test should ever fail, we should re-examine the WebGL state saving/restoring logic in the InjectedScriptModule to include any latest changes to the API.
 
+ERROR: Could not create a WebGL context.
 Constants for gl.isEnabled():
-BLEND
-CULL_FACE
-DEPTH_TEST
-DITHER
-POLYGON_OFFSET_FILL
-SAMPLE_ALPHA_TO_COVERAGE
-SAMPLE_COVERAGE
-SCISSOR_TEST
-STENCIL_TEST
 
 Constants for gl.pixelStorei():
-PACK_ALIGNMENT
-UNPACK_ALIGNMENT
-UNPACK_COLORSPACE_CONVERSION_WEBGL
-UNPACK_FLIP_Y_WEBGL
-UNPACK_PREMULTIPLY_ALPHA_WEBGL
 
 Constants for gl.getTexParameter():
-TEXTURE_MAG_FILTER
-TEXTURE_MIN_FILTER
-TEXTURE_WRAP_S
-TEXTURE_WRAP_T
 
-Constants for gl.getVertexAttrib():
-CURRENT_VERTEX_ATTRIB
-VERTEX_ATTRIB_ARRAY_BUFFER_BINDING
-VERTEX_ATTRIB_ARRAY_ENABLED
-VERTEX_ATTRIB_ARRAY_NORMALIZED
-VERTEX_ATTRIB_ARRAY_SIZE
-VERTEX_ATTRIB_ARRAY_STRIDE
-VERTEX_ATTRIB_ARRAY_TYPE
-
-Constants for gl.getVertexAttribOffset():
-VERTEX_ATTRIB_ARRAY_POINTER
-
-Constants for gl.getParameter() that we do not track in InjectedScriptModule:
-ALIASED_LINE_WIDTH_RANGE
-ALIASED_POINT_SIZE_RANGE
-ALPHA_BITS
-BLUE_BITS
-COMPRESSED_TEXTURE_FORMATS
-DEPTH_BITS
-GREEN_BITS
-MAX_COMBINED_TEXTURE_IMAGE_UNITS
-MAX_CUBE_MAP_TEXTURE_SIZE
-MAX_FRAGMENT_UNIFORM_VECTORS
-MAX_RENDERBUFFER_SIZE
-MAX_TEXTURE_IMAGE_UNITS
-MAX_TEXTURE_SIZE
-MAX_VARYING_VECTORS
-MAX_VERTEX_ATTRIBS
-MAX_VERTEX_TEXTURE_IMAGE_UNITS
-MAX_VERTEX_UNIFORM_VECTORS
-MAX_VIEWPORT_DIMS
-RED_BITS
-RENDERER
-SAMPLES
-SAMPLE_BUFFERS
-SHADING_LANGUAGE_VERSION
-STENCIL_BITS
-SUBPIXEL_BITS
-VENDOR
-VERSION
-

[Csaba Osztrogonác]

And it crashes on our parallel NRWT bot:

crash log for DumpRenderTree (pid 21164):
STDOUT: <empty>
STDERR: 1   0xf6bc96cc /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x17636cc) [0xf6bc96cc]
STDERR: 2   0xf77db400 [0xf77db400]
STDERR: 3   0xf4346a36 /usr/lib/libGL.so.1(+0x60a36) [0xf4346a36]
STDERR: 4   0xf63a12f3 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xf3b2f3) [0xf63a12f3]
STDERR: 5   0xf639897f /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xf3297f) [0xf639897f]
STDERR: 6   0xf639900d /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xf3300d) [0xf639900d]
STDERR: 7   0xf6379d97 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xf13d97) [0xf6379d97]
STDERR: 8   0xf5c01ff4 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x79bff4) [0xf5c01ff4]
STDERR: 9   0xf58d0465 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x46a465) [0xf58d0465]
STDERR: 10  0xf65c2b1b /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x115cb1b) [0xf65c2b1b]
STDERR: 11  0xeec3742f [0xeec3742f]
STDERR: 12  0xf6a25a6f /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x15bfa6f) [0xf6a25a6f]
STDERR: 13  0xf6a1ff17 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x15b9f17) [0xf6a1ff17]
STDERR: 14  0xf6b0ad5c /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(_ZN3JSC4callEPNS_9ExecStateENS_7JSValueENS_8CallTypeERKNS_8CallDataES2_RKNS_7ArgListE+0x60) [0xf6b0ad5c]
STDERR: 15  0xf58cb3a6 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x4653a6) [0xf58cb3a6]
STDERR: 16  0xf5aba922 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x654922) [0xf5aba922]
STDERR: 17  0xf5abaaf1 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x654af1) [0xf5abaaf1]
STDERR: 18  0xf5e29e29 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x9c3e29) [0xf5e29e29]
STDERR: 19  0xf5e29ff4 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x9c3ff4) [0xf5e29ff4]
STDERR: 20  0xf5a70bbc /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x60abbc) [0xf5a70bbc]
STDERR: 21  0xf5a8f26c /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x62926c) [0xf5a8f26c]
STDERR: 22  0xf5db4759 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x94e759) [0xf5db4759]
STDERR: 23  0xf5dbc71b /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x95671b) [0xf5dbc71b]
STDERR: 24  0xf5da349e /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x93d49e) [0xf5da349e]
STDERR: 25  0xf5def64a /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x98964a) [0xf5def64a]
STDERR: 26  0xf5de5ace /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x97face) [0xf5de5ace]
STDERR: 27  0xf5defbfb /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x989bfb) [0xf5defbfb]
STDERR: 28  0xf5de5752 /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x97f752) [0xf5de5752]
STDERR: 29  0xf611702c /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xcb102c) [0xf611702c]
STDERR: 30  0xf6113f1e /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xcadf1e) [0xf6113f1e]
STDERR: 31  0xf611444c /home/webkitbuildbot/slaves/release32bit-NRWT/buildslave/qt-linux-32-release-NRWT/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xcae44c) [0xf611444c]

[Andrey Adaikin]

It fails to create a WebGL context for some reason. Any insight of why that may be?

[Kenneth Russell]

Do any other WebGL tests run on that bot? Some of the bots aren't configured with a real GPU, and some of the WebKit ports aren't set up to use a software renderer like Mesa for running WebGL related layout tests. It might be necessary to skip this new test on some ports.

[Andrey Adaikin]

Created attachment 161425 [details]
Patch

[Andrey Adaikin]

Created attachment 161427 [details]
Rebased patch

[WebKit Review Bot]

Comment on attachment 161427 [details]
Rebased patch

Clearing flags on attachment: 161427

Committed r127236: <http://trac.webkit.org/changeset/127236>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.