Bug 95170 - [WK2] Use explicit constructor in PageClientImpl
Summary: [WK2] Use explicit constructor in PageClientImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 23:09 PDT by Kangil Han
Modified: 2012-08-28 22:09 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.78 KB, patch)
2012-08-27 23:10 PDT, Kangil Han 		mrobinson: review-
Details | Formatted Diff | Diff
patch (1.81 KB, patch)
2012-08-28 19:40 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-08-27 23:09:18 PDT 
Added explicit keyword to constructor in PageClientImpl.
Comment 1 Kangil Han 2012-08-27 23:10:56 PDT 
Created attachment 160906 [details]
patch
Comment 2 WebKit Review Bot 2012-08-27 23:13:19 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2012-08-28 19:06:24 PDT 
Comment on attachment 160906 [details]
patch

Nowhere in the patch or the bug do you explain why you are making this change... Does it fix or prevent any bugs?
Comment 4 Kangil Han 2012-08-28 19:18:22 PDT 
(In reply to comment #3)
> (From update of attachment 160906 [details])
> Nowhere in the patch or the bug do you explain why you are making this change... Does it fix or prevent any bugs?

Yes, you are right. I didn't explain why explicit keyword is needed in this patch.
I will get back with updated changelog!
Thanks!
Comment 5 Kangil Han 2012-08-28 19:40:50 PDT 
Created attachment 161119 [details]
patch

Done!
Comment 6 WebKit Review Bot 2012-08-28 22:09:43 PDT 
Comment on attachment 161119 [details]
patch

Clearing flags on attachment: 161119

Committed r126958: <http://trac.webkit.org/changeset/126958>
Comment 7 WebKit Review Bot 2012-08-28 22:09:47 PDT 
All reviewed patches have been landed.  Closing bug.