Bug 95148 - Remove opcode definition autogen for now
Summary: Remove opcode definition autogen for now
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 15:54 PDT by Oliver Hunt
Modified: 2012-08-27 16:02 PDT (History)
1 user (show)

See Also:


Attachments
Patch (45.31 KB, patch)
2012-08-27 15:55 PDT, Oliver Hunt
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-08-27 15:54:34 PDT
Remove opcode definition autogen for now
Comment 1 Oliver Hunt 2012-08-27 15:55:13 PDT
Created attachment 160838 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-27 15:58:48 PDT
Attachment 160838 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/Opcode.h:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2012-08-27 16:01:05 PDT
Comment on attachment 160838 [details]
Patch

rs=me
Comment 4 Oliver Hunt 2012-08-27 16:02:33 PDT
Committed r126814: <http://trac.webkit.org/changeset/126814>