Bug 95124 - [V8] Clean up reportFatalError in V8DOMWindowShell.cpp
Summary: [V8] Clean up reportFatalError in V8DOMWindowShell.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 94909
  Show dependency tree / graph
 
Reported: 2012-08-27 13:54 PDT by Adam Barth
Modified: 2012-08-27 14:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2012-08-27 13:56 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-08-27 13:54:43 PDT 
[V8] Clean up reportFatalError in V8DOMWindowShell.cpp
Comment 1 Adam Barth 2012-08-27 13:56:44 PDT 
Created attachment 160799 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-27 13:59:43 PDT 
Comment on attachment 160799 [details]
Patch

Rejecting attachment 160799 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
Hunk #1 FAILED at 83.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8DOMWindowShell.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13610430
Comment 3 WebKit Review Bot 2012-08-27 14:49:21 PDT 
Comment on attachment 160799 [details]
Patch

Clearing flags on attachment: 160799

Committed r126799: <http://trac.webkit.org/changeset/126799>
Comment 4 WebKit Review Bot 2012-08-27 14:49:24 PDT 
All reviewed patches have been landed.  Closing bug.