Bug 95119 – [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[W. James MacLean]

[chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.

[W. James MacLean]

Created attachment 160790 [details]
Patch

Add plumbing for flag to enable/disable gesture tap highlights. We'll make the default behaviour to be enabled in order to not upset the layout test framework.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 160790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160790&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:735
>  #if OS(LINUX)

Why OS(LINUX)?  Presumably this is something we'll want on other OS, like Android.  Perhaps this should be an ENABLE (or just compiled in all the time).

[W. James MacLean]

(In reply to comment #3)
> (From update of attachment 160790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160790&action=review
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:735
> >  #if OS(LINUX)
> 
> Why OS(LINUX)?  Presumably this is something we'll want on other OS, like Android.  Perhaps this should be an ENABLE (or just compiled in all the time).

This feature is new, and we're restricting to testing on Linux for the time being. We will be removing the restriction (to allow Android, Win8, others?) once we have a little more experience with it.

[W. James MacLean]

Created attachment 161281 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 161281 [details]
Patch for landing

Clearing flags on attachment: 161281

Committed r127076: <http://trac.webkit.org/changeset/127076>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.