Bug 95119 - [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.
Summary: [chromium] Add WebSettings support for flag to enable/disable gesture tap hig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 13:26 PDT by W. James MacLean
Modified: 2012-08-29 18:23 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.02 KB, patch)
2012-08-27 13:28 PDT, W. James MacLean
no flags Details | Formatted Diff | Diff
Patch for landing (5.11 KB, patch)
2012-08-29 12:16 PDT, W. James MacLean
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description W. James MacLean 2012-08-27 13:26:19 PDT
[chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.
Comment 1 W. James MacLean 2012-08-27 13:28:01 PDT
Created attachment 160790 [details]
Patch

Add plumbing for flag to enable/disable gesture tap highlights. We'll make the default behaviour to be enabled in order to not upset the layout test framework.
Comment 2 WebKit Review Bot 2012-08-27 13:31:29 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-08-29 09:41:36 PDT
Comment on attachment 160790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160790&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:735
>  #if OS(LINUX)

Why OS(LINUX)?  Presumably this is something we'll want on other OS, like Android.  Perhaps this should be an ENABLE (or just compiled in all the time).
Comment 4 W. James MacLean 2012-08-29 11:02:55 PDT
(In reply to comment #3)
> (From update of attachment 160790 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160790&action=review
> 
> > Source/WebKit/chromium/src/WebViewImpl.cpp:735
> >  #if OS(LINUX)
> 
> Why OS(LINUX)?  Presumably this is something we'll want on other OS, like Android.  Perhaps this should be an ENABLE (or just compiled in all the time).

This feature is new, and we're restricting to testing on Linux for the time being. We will be removing the restriction (to allow Android, Win8, others?) once we have a little more experience with it.
Comment 5 W. James MacLean 2012-08-29 12:16:30 PDT
Created attachment 161281 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-08-29 18:23:29 PDT
Comment on attachment 161281 [details]
Patch for landing

Clearing flags on attachment: 161281

Committed r127076: <http://trac.webkit.org/changeset/127076>
Comment 7 WebKit Review Bot 2012-08-29 18:23:33 PDT
All reviewed patches have been landed.  Closing bug.