Bug 95115 - [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
Summary: [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 12:11 PDT by James Robinson
Modified: 2012-08-27 12:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2012-08-27 12:12 PDT, James Robinson 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-08-27 12:11:28 PDT 
[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
Comment 1 James Robinson 2012-08-27 12:12:07 PDT 
Created attachment 160770 [details]
Patch
Comment 2 Adam Barth 2012-08-27 12:12:49 PDT 
Hum...
Comment 3 James Robinson 2012-08-27 12:15:55 PDT 
Committed r126784: <http://trac.webkit.org/changeset/126784>
Comment 4 Daniel Bates 2012-08-27 12:18:50 PDT 
Comment on attachment 160770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160770&action=review

> Tools/Scripts/run-chromium-webkit-unit-tests:40
>  # perl's "system" function's return value has to be right shifted by 8 to get the program's exit code.

Nit: Please remove this comment since we're using the convenience function exitStatus().

> Tools/Scripts/run-chromium-webkit-unit-tests:41
> +exit exitStatus(system ($pathToBinary, @ARGV));

Nit: There is an extraneous space after "system". I know that this space was in the original code. I suggest we remove it when using C-like functional notation.
Comment 5 James Robinson 2012-08-27 12:20:32 PDT 
(In reply to comment #4)
> (From update of attachment 160770 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160770&action=review
> 
> > Tools/Scripts/run-chromium-webkit-unit-tests:40
> >  # perl's "system" function's return value has to be right shifted by 8 to get the program's exit code.
> 
> Nit: Please remove this comment since we're using the convenience function exitStatus().
> 

Done

> > Tools/Scripts/run-chromium-webkit-unit-tests:41
> > +exit exitStatus(system ($pathToBinary, @ARGV));
> 
> Nit: There is an extraneous space after "system". I know that this space was in the original code. I suggest we remove it when using C-like functional notation.

Not a bad idea. Do we have any sort of perl style guidelines/recommendations?
Comment 6 Daniel Bates 2012-08-27 12:23:58 PDT 
(In reply to comment #5)
> > > Tools/Scripts/run-chromium-webkit-unit-tests:41
> > > +exit exitStatus(system ($pathToBinary, @ARGV));
> > 
> > Nit: There is an extraneous space after "system". I know that this space was in the original code. I suggest we remove it when using C-like functional notation.
> 
> Not a bad idea. Do we have any sort of perl style guidelines/recommendations?

No, we don't have a written style guide explicitly for our Perl code. We tend to follow the WebKit Code Style Guidelines.