Bug 95115 – [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests

[James Robinson]

Created attachment 160770 [details]
Patch

[Adam Barth]

Hum...

[James Robinson]

Committed r126784: <http://trac.webkit.org/changeset/126784>

[Daniel Bates]

Comment on attachment 160770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160770&action=review

> Tools/Scripts/run-chromium-webkit-unit-tests:40
>  # perl's "system" function's return value has to be right shifted by 8 to get the program's exit code.

Nit: Please remove this comment since we're using the convenience function exitStatus().

> Tools/Scripts/run-chromium-webkit-unit-tests:41
> +exit exitStatus(system ($pathToBinary, @ARGV));

Nit: There is an extraneous space after "system". I know that this space was in the original code. I suggest we remove it when using C-like functional notation.

[James Robinson]

(In reply to comment #4)
> (From update of attachment 160770 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160770&action=review
> 
> > Tools/Scripts/run-chromium-webkit-unit-tests:40
> >  # perl's "system" function's return value has to be right shifted by 8 to get the program's exit code.
> 
> Nit: Please remove this comment since we're using the convenience function exitStatus().
> 

Done

> > Tools/Scripts/run-chromium-webkit-unit-tests:41
> > +exit exitStatus(system ($pathToBinary, @ARGV));
> 
> Nit: There is an extraneous space after "system". I know that this space was in the original code. I suggest we remove it when using C-like functional notation.

Not a bad idea. Do we have any sort of perl style guidelines/recommendations?

[Daniel Bates]

(In reply to comment #5)
> > > Tools/Scripts/run-chromium-webkit-unit-tests:41
> > > +exit exitStatus(system ($pathToBinary, @ARGV));
> > 
> > Nit: There is an extraneous space after "system". I know that this space was in the original code. I suggest we remove it when using C-like functional notation.
> 
> Not a bad idea. Do we have any sort of perl style guidelines/recommendations?

No, we don't have a written style guide explicitly for our Perl code. We tend to follow the WebKit Code Style Guidelines.