One path to accomplish Bug 93444 - Web Inspector: SourceFrame shouldn't be a View
would move the View methods in SourceFrame to _textEditor. One set of such methods is
clearLineHighlight() is not a View method but it is part of DefaultTextEditor.
Created attachment 160794 [details]
I am not able to get webkit-patch upload to work
Incremental step towards bug 93444. Refactor SourceFrame methods related to highlightLine() to delegate to its ._textEditor, a View object. DefaultTextEditor gets a new method as the delegatee, canHighlightLine().
No change in function; no new tests; compile-front-end.py passes these files.
Created attachment 160804 [details]
Created attachment 162337 [details]
Comment on attachment 162337 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=162337&action=review
> + return this._textEditor.canHighlightLine();
SourceFrame should be always able to highlight the line.
> - delete this._lineToHighlight
What about the case when we get request for the line highlight before the content has loaded into the text editor? Like stopping on a breakpoint that leads to the SourceFrame being opened.