Bug 95114 – Web Inspector: Refactor SourceFrame to delegate highlightLine() to _textEditor

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[johnjbarton]

One path to accomplish Bug 93444 - Web Inspector: SourceFrame shouldn't be a View 
would move the View methods in SourceFrame to _textEditor.  One set of such methods is
  highlightLine() canHighlightLine()

clearLineHighlight() is not a View method but it is part of DefaultTextEditor.

[johnjbarton]

Created attachment 160794 [details]
git format-patch 

I am not able to get webkit-patch upload to work

[johnjbarton]

ChangeLog message:

Incremental step towards bug 93444. Refactor SourceFrame methods related to highlightLine() to delegate to its ._textEditor, a View object. DefaultTextEditor gets a new method as the delegatee, canHighlightLine().

No change in function; no new tests; compile-front-end.py passes these files.

[johnjbarton]

Created attachment 160804 [details]
Patch

[johnjbarton]

Created attachment 162337 [details]
Patch

[Pavel Feldman]

Comment on attachment 162337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162337&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:173
> +        return this._textEditor.canHighlightLine();

SourceFrame should be always able to highlight the line.

> Source/WebCore/inspector/front-end/SourceFrame.js:-193
> -                delete this._lineToHighlight

What about the case when we get request for the line highlight before the content has loaded into the text editor? Like stopping on a breakpoint that leads to the SourceFrame being opened.