Bug 95113 - [BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient
Summary: [BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 12:07 PDT by Parth Patel
Modified: 2012-08-28 07:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.57 KB, patch)
2012-08-27 12:18 PDT, Parth Patel
no flags Details | Formatted Diff | Diff
Patch (3.01 KB, patch)
2012-08-28 06:27 PDT, Parth Patel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Parth Patel 2012-08-27 12:07:13 PDT
Refactoring has lead to relocation of many or all methods from Class BlackBerryPlatformClient to other classes.Some files include BlackBerryPlatformClient but does not use its instance thus these includes has to be removed.
Comment 1 Parth Patel 2012-08-27 12:18:03 PDT
Created attachment 160772 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-27 13:10:24 PDT
Comment on attachment 160772 [details]
Patch

rs=me.
Comment 3 WebKit Review Bot 2012-08-27 13:13:21 PDT
Comment on attachment 160772 [details]
Patch

Rejecting attachment 160772 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
cceeded at 1 with fuzz 3.
patching file Source/WebCore/platform/network/blackberry/NetworkManager.cpp
patching file Source/WebKit/blackberry/Api/BackingStore.cpp
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 FAILED at 155.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13612374
Comment 4 Parth Patel 2012-08-28 06:27:13 PDT
Created attachment 160960 [details]
Patch
Comment 5 Parth Patel 2012-08-28 06:44:15 PDT
Comment on attachment 160960 [details]
Patch

set flag to commit-queue? after review+
Comment 6 Kentaro Hara 2012-08-28 06:44:41 PDT
Comment on attachment 160960 [details]
Patch

ok
Comment 7 WebKit Review Bot 2012-08-28 07:41:12 PDT
Comment on attachment 160960 [details]
Patch

Clearing flags on attachment: 160960

Committed r126875: <http://trac.webkit.org/changeset/126875>
Comment 8 WebKit Review Bot 2012-08-28 07:41:15 PDT
All reviewed patches have been landed.  Closing bug.