Bug 95095 - Simplify cloning of inline style (below Node.cloneNode)
Summary: Simplify cloning of inline style (below Node.cloneNode)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 09:36 PDT by Andreas Kling
Modified: 2012-08-28 06:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.54 KB, patch)
2012-08-27 09:37 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-08-27 09:36:40 PDT 
We should just use StylePropertySet::copy() instead of cloning everything manually in ElementAttributeData::cloneDataFrom().
Comment 1 Andreas Kling 2012-08-27 09:37:07 PDT 
Created attachment 160733 [details]
Patch
Comment 2 Andreas Kling 2012-08-27 11:04:49 PDT 
CC'ing Antti who is a pretty cool guy.
Comment 3 Eric Seidel (no email) 2012-08-27 13:14:10 PDT 
Comment on attachment 160733 [details]
Patch

Looks reasonable.
Comment 4 WebKit Review Bot 2012-08-28 06:15:38 PDT 
Comment on attachment 160733 [details]
Patch

Clearing flags on attachment: 160733

Committed r126872: <http://trac.webkit.org/changeset/126872>
Comment 5 WebKit Review Bot 2012-08-28 06:15:41 PDT 
All reviewed patches have been landed.  Closing bug.