Bug 95088 - Web Inspector: Debugger should break on failed assertions in Break on exceptions mode.
Summary: Web Inspector: Debugger should break on failed assertions in Break on excepti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-27 08:02 PDT by Vsevolod Vlasov
Modified: 2012-08-27 08:43 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.87 KB, patch)
2012-08-27 08:12 PDT, Vsevolod Vlasov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-08-27 08:02:55 PDT 
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-08-27 08:12:28 PDT 
Created attachment 160723 [details]
Patch
Comment 2 Yury Semikhatsky 2012-08-27 08:25:52 PDT 
Comment on attachment 160723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160723&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:894
> +    if (InspectorDebuggerAgent* debuggerAgent = instrumentingAgents->inspectorDebuggerAgent())

I would call console agent first in order to have the message appear in the console before pausing. We had user complains about exceptions being logged only after you resume.
Comment 3 Vsevolod Vlasov 2012-08-27 08:43:05 PDT 
Committed r126764: <http://trac.webkit.org/changeset/126764>