Bug 95074 - Datalist RTL test fails on ports that have progress indicator on the range groove
Summary: Datalist RTL test fails on ports that have progress indicator on the range gr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on: 94595
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-27 05:02 PDT by Thiago Marcos P. Santos
Modified: 2012-08-28 05:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2012-08-27 06:52 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Problem with the current test implementation (36.41 KB, image/png)
2012-08-27 07:08 PDT, Thiago Marcos P. Santos 		no flags Details
Patch (3.35 KB, patch)
2012-08-28 04:43 PDT, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-08-27 05:02:26 PDT 
One solution might be set the initial value to somewhere in the corners.

Test case:
fast/forms/datalist/input-appearance-range-with-datalist-rtl.html
Comment 1 Thiago Marcos P. Santos 2012-08-27 06:49:24 PDT 
(In reply to comment #0)
> One solution might be set the initial value to somewhere in the corners.
> 
> Test case:
> fast/forms/datalist/input-appearance-range-with-datalist-rtl.html

I tried doing this plus applying a horizontal flip transformation but it didn't work. The only solution I see now is applying a mask on top of the slider, but keep the ticks visible.
Comment 2 Thiago Marcos P. Santos 2012-08-27 06:52:18 PDT 
Created attachment 160709 [details]
Patch
Comment 3 Thiago Marcos P. Santos 2012-08-27 07:08:40 PDT 
Created attachment 160713 [details]
Problem with the current test implementation

The problem should affect EFL and Qt at least.
Comment 4 Kent Tamura 2012-08-27 21:15:06 PDT 
(In reply to comment #3)
> Created an attachment (id=160713) [details]
> Problem with the current test implementation
> 
> The problem should affect EFL and Qt at least.

Ah, I didn't know we have such slider implementations.

I think the patch is ok.  Converting the test from a ref test to a pixel test is also acceptable.
Comment 5 Kent Tamura 2012-08-27 21:15:35 PDT 
Comment on attachment 160709 [details]
Patch

cq- because of purple EWS.
Comment 6 Thiago Marcos P. Santos 2012-08-28 04:43:21 PDT 
Created attachment 160954 [details]
Patch

Re-uploading. The dependency for this patch just landed.
Comment 7 WebKit Review Bot 2012-08-28 05:49:41 PDT 
Comment on attachment 160954 [details]
Patch

Clearing flags on attachment: 160954

Committed r126869: <http://trac.webkit.org/changeset/126869>
Comment 8 WebKit Review Bot 2012-08-28 05:49:45 PDT 
All reviewed patches have been landed.  Closing bug.