Bug 95061 – [Tests] Make fast/canvas/canvas-scale-shadowBlur.html in conformance with spec.

• Status: UNCONFIRMED
• Component: Tools / Tests

[Dongseong Hwang]

This test failed on firefox because this test assumed the pixel apart from 2σ is #0000.
However, the pixel apart from 2σ is not #0000 mathematically. The exact value of
gaussian function f(2σ) is 0.1353. This means we should check
shouldBeTrue('d[0] == 255 && d[3] < 14'), but some platforms do not render
anything on the pixel apart from 2σ. i.e. skia.
So we need complex checking mechanism for d[0] and d[3] in order to be
harmonized with both the mathematical expectation and the practical expectation.

[Dongseong Hwang]

Created attachment 160675 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160675 [details]
Patch

Attachment 160675 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13622139

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-scale-shadowBlur.html
fast/canvas/canvas-scale-shadowBlur.html

[WebKit Review Bot]

Created attachment 160737 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Eric Seidel (no email)]

Looks like your updated tests fails on teh cr-linux bot.

[Dongseong Hwang]

(In reply to comment #4)
> Looks like your updated tests fails on teh cr-linux bot.

Yes, cr-linux bot failed.

However, I can not understand why cr-linux bot applied only new test file without the new expected file belonging to this patch. I think it maybe flaky nature of cr-linux.

I'll upload this patch again.

[Dongseong Hwang]

Created attachment 160851 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160851 [details]
Patch

Attachment 160851 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13639115

New failing tests:
platform/chromium/virtual/gpu/fast/canvas/canvas-scale-shadowBlur.html
fast/canvas/canvas-scale-shadowBlur.html

[WebKit Review Bot]

Created attachment 160874 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Dongseong Hwang]

Created attachment 160893 [details]
Patch

[Dongseong Hwang]

(In reply to comment #5)
> (In reply to comment #4)
> > Looks like your updated tests fails on teh cr-linux bot.

I had misunderstood the reason.

There are 4 platform specific expected files for relieving this problem.
cr-linux bot failed, because I did not update the expected file of cr-linux.
We does not need 4 platform specific expected files anymore, so I removed those.

[Anders Carlsson]

Comment on attachment 160893 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.