Bug 95060 - Regression(r126721): bindings-tests results need to be updated
Summary: Regression(r126721): bindings-tests results need to be updated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 95021
  Show dependency tree / graph
 
Reported: 2012-08-27 02:13 PDT by Chris Dumez
Modified: 2012-08-27 02:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.88 KB, patch)
2012-08-27 02:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-08-27 02:13:12 PDT 
After r126721 (Bug 95021), bindings-generation-tests started failing:
FAIL: (JS) JSTestObj.cpp
--- WebCore/bindings/scripts/test/JS/JSTestObj.cpp    2012-08-24 02:14:04.835189616 -0700
+++ /tmp/tmpRz6I1v/JSTestObj.cpp    2012-08-27 01:33:11.159781908 -0700
@@ -2593,10 +2593,8 @@
     COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag);
     ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren());
     Base::visitChildren(thisObject, visitor);
-    if (thisObject->m_cachedAttribute1)
-        visitor.append(&thisObject->m_cachedAttribute1);
-    if (thisObject->m_cachedAttribute2)
-        visitor.append(&thisObject->m_cachedAttribute2);
+    visitor.append(&thisObject->m_cachedAttribute1);
+    visitor.append(&thisObject->m_cachedAttribute2);
 }

FAIL: (JS) JSTestSerializedScriptValueInterface.cpp
--- WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp    2012-07-27 10:21:26.271861874 -0700
+++ /tmp/tmpwwIxP6/JSTestSerializedScriptValueInterface.cpp    2012-08-27 01:33:11.579798199 -0700
@@ -356,10 +356,8 @@
     COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag);
     ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren());
     Base::visitChildren(thisObject, visitor);
-    if (thisObject->m_cachedValue)
-        visitor.append(&thisObject->m_cachedValue);
-    if (thisObject->m_cachedReadonlyValue)
-        visitor.append(&thisObject->m_cachedReadonlyValue);
+    visitor.append(&thisObject->m_cachedValue);
+    visitor.append(&thisObject->m_cachedReadonlyValue);
 }

The expected results need to be regenerated.
Comment 1 Chris Dumez 2012-08-27 02:15:31 PDT 
Created attachment 160676 [details]
Patch
Comment 2 Kentaro Hara 2012-08-27 02:16:34 PDT 
Comment on attachment 160676 [details]
Patch

Thanks for the quick fix!
Comment 3 WebKit Review Bot 2012-08-27 02:45:14 PDT 
Comment on attachment 160676 [details]
Patch

Clearing flags on attachment: 160676

Committed r126738: <http://trac.webkit.org/changeset/126738>
Comment 4 WebKit Review Bot 2012-08-27 02:45:17 PDT 
All reviewed patches have been landed.  Closing bug.