Bug 95049 - [Chromium-Android] Move webkit_unit_tests_apk and TestWebKitAPI_apk into condition block [gtest_target_type == "shared_library"'
Summary: [Chromium-Android] Move webkit_unit_tests_apk and TestWebKitAPI_apk into cond...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Android
: P2 Normal
Assignee: Johnny(Jianning) Ding
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-26 23:09 PDT by Johnny(Jianning) Ding
Modified: 2012-08-27 00:04 PDT (History)
5 users (show)

See Also:


Attachments
patch v1 (1.90 KB, patch)
2012-08-26 23:18 PDT, Johnny(Jianning) Ding
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johnny(Jianning) Ding 2012-08-26 23:09:40 PDT
Some test targets need to be wrapped in APK on Chromium Android platform only if the setting of gtest_target_type is "shared_library".
We should explicitly put such test targets into a condition block ['OS=="android" and gtest_target_type == "shared_library"']
Comment 1 Johnny(Jianning) Ding 2012-08-26 23:18:01 PDT
Created attachment 160648 [details]
patch v1
Comment 2 Adam Barth 2012-08-26 23:45:49 PDT
Comment on attachment 160648 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review

> Source/WebKit/chromium/ChangeLog:9
> +        Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"

Ideally, the ChangeLog would include the "why" behind the change.  You've explained the why in Comment #0.  You might just want to copy it into the ChangeLog.
Comment 3 Johnny(Jianning) Ding 2012-08-26 23:57:45 PDT
(In reply to comment #2)
> (From update of attachment 160648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review
> 
> > Source/WebKit/chromium/ChangeLog:9
> > +        Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"
> 
> Ideally, the ChangeLog would include the "why" behind the change.  You've explained the why in Comment #0.  You might just want to copy it into the ChangeLog.

Thank, Adam! Will follow it in the future patchs.
Comment 4 WebKit Review Bot 2012-08-27 00:04:02 PDT
Comment on attachment 160648 [details]
patch v1

Clearing flags on attachment: 160648

Committed r126729: <http://trac.webkit.org/changeset/126729>
Comment 5 WebKit Review Bot 2012-08-27 00:04:05 PDT
All reviewed patches have been landed.  Closing bug.