Bug 95049 – [Chromium-Android] Move webkit_unit_tests_apk and TestWebKitAPI_apk into condition block [gtest_target_type == "shared_library"'

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Johnny(Jianning) Ding]

Some test targets need to be wrapped in APK on Chromium Android platform only if the setting of gtest_target_type is "shared_library".
We should explicitly put such test targets into a condition block ['OS=="android" and gtest_target_type == "shared_library"']

[Johnny(Jianning) Ding]

Created attachment 160648 [details]
patch v1

[Adam Barth]

Comment on attachment 160648 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review

> Source/WebKit/chromium/ChangeLog:9
> +        Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"

Ideally, the ChangeLog would include the "why" behind the change.  You've explained the why in Comment #0.  You might just want to copy it into the ChangeLog.

[Johnny(Jianning) Ding]

(In reply to comment #2)
> (From update of attachment 160648 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review
> 
> > Source/WebKit/chromium/ChangeLog:9
> > +        Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"
> 
> Ideally, the ChangeLog would include the "why" behind the change.  You've explained the why in Comment #0.  You might just want to copy it into the ChangeLog.

Thank, Adam! Will follow it in the future patchs.

[WebKit Review Bot]

Comment on attachment 160648 [details]
patch v1

Clearing flags on attachment: 160648

Committed r126729: <http://trac.webkit.org/changeset/126729>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.