Initialized m_hasNonEmptyList to fix a valgrind uninitialized read
Created attachment 160637 [details] Patch
Comment on attachment 160637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160637&action=review > Source/WebCore/html/HTMLInputElement.cpp:1529 > +#if ENABLE(DATALIST_ELEMENT) > if (!m_hasNonEmptyList) > return 0; > +#endif You don't need to add #if ENABLE(DATALIST_ELEMENT) because HTMLInputElement::dataList() is in #if ENABLE_DATALIST_ELEMENT).
Comment on attachment 160637 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160637&action=review >> Source/WebCore/html/HTMLInputElement.cpp:1529 >> +#endif > > You don't need to add #if ENABLE(DATALIST_ELEMENT) because HTMLInputElement::dataList() is in #if ENABLE_DATALIST_ELEMENT). Oh, indeed. Thanks, I removed this bit again.
Created attachment 160638 [details] Patch for landing
Comment on attachment 160638 [details] Patch for landing Clearing flags on attachment: 160638 Committed r126727: <http://trac.webkit.org/changeset/126727>
All reviewed patches have been landed. Closing bug.