Bug 95026 - Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
Summary: Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.8
: P1 Normal
Assignee: Brady Eidson
URL: http://travelbird.nl/3265/wijnhelling...
Keywords: InRadar, Regression
: 95692 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-08-26 00:27 PDT by Jack van Soest
Modified: 2012-09-05 08:38 PDT (History)
5 users (show)

See Also:

Attachments
Crash log (61.04 KB, text/plain)
2012-08-26 00:27 PDT, Jack van Soest 		no flags Details
Patch v1 - Fix + regression test (13.94 KB, patch)
2012-09-04 17:26 PDT, Brady Eidson 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jack van Soest 2012-08-26 00:27:35 PDT 
Created attachment 160594 [details]
Crash log

Webkit suddenly crashes. It happens daily. With Safari no problems
Comment 1 Alexey Proskuryakov 2012-08-27 10:54:15 PDT 
Brady, this sounds related to async instantiation.

<rdar://problem/12142226>
Comment 2 Brady Eidson 2012-09-04 16:49:06 PDT 
*** Bug 95692 has been marked as a duplicate of this bug. ***
Comment 3 Brady Eidson 2012-09-04 16:50:44 PDT 
Dupe https://bugs.webkit.org/show_bug.cgi?id=95692 points out that this happens - even with synchronous initialization - after the plugin fails to initialize.

The code change to fix this is simple.  I'm working on a plugin test for regression testing that fix.
Comment 4 Brady Eidson 2012-09-04 17:26:17 PDT 
Created attachment 162136 [details]
Patch v1 - Fix + regression test
Comment 5 Andy Estes 2012-09-04 18:14:02 PDT 
Comment on attachment 162136 [details]
Patch v1 - Fix + regression test

r=me, but you should let the EWS tell you this won't break a non-Mac build before landing.
Comment 6 Brady Eidson 2012-09-04 18:16:24 PDT 
(In reply to comment #5)
> (From update of attachment 162136 [details])
> r=me, but you should let the EWS tell you this won't break a non-Mac build before landing.

Have been waiting patiently since I submitted to EWS.  Thanks.
Comment 7 Brady Eidson 2012-09-05 08:38:55 PDT 
http://trac.webkit.org/changeset/127595