Bug 95019 - [BlackBerry] Shrink the in-region nested scrollable list as soon as we can
Summary: [BlackBerry] Shrink the in-region nested scrollable list as soon as we can
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks: 95020
  Show dependency treegraph
 
Reported: 2012-08-25 19:35 PDT by Antonio Gomes
Modified: 2012-08-27 08:55 PDT (History)
6 users (show)

See Also:


Attachments
patch (6.82 KB, patch)
2012-08-25 19:44 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
patch (6.82 KB, patch)
2012-08-26 22:18 PDT, Antonio Gomes
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-08-25 19:35:59 PDT
That can be done as soon as the client actually starts scrolling a given layer A.

All other layers cached, if any, can be dismissed at this point.
Comment 1 Antonio Gomes 2012-08-25 19:44:42 PDT
Created attachment 160584 [details]
patch
Comment 2 George Staikos 2012-08-25 20:15:22 PDT
Comment on attachment 160584 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160584&action=review

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:162
> +    while(it != end) {

missing space?

> Source/WebKit/blackberry/ChangeLog:13
> +        Patch providesa simple solution to that.

Missing space?
Comment 3 Antonio Gomes 2012-08-26 22:18:05 PDT
Created attachment 160632 [details]
patch

(In reply to comment #2)
> (From update of attachment 160584 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160584&action=review
> 
> > Source/WebKit/blackberry/Api/InRegionScroller.cpp:162
> > +    while(it != end) {
> 
> missing space?
> 
> > Source/WebKit/blackberry/ChangeLog:13
> > +        Patch providesa simple solution to that.
> 
> Missing space?

Both fixed.
Comment 4 Rob Buis 2012-08-27 06:44:39 PDT
Comment on attachment 160632 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160632&action=review

LGTM.

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:172
> +        // ::erase invalidades the iterators.

Typo: invalidates

> Source/WebKit/blackberry/ChangeLog:10
> +        of each layer, and on the diretion user swipes its finger.

Typo: direction
Comment 5 Antonio Gomes 2012-08-27 08:55:14 PDT
https://trac.webkit.org/changeset/126767