Bug 95019 – [BlackBerry] Shrink the in-region nested scrollable list as soon as we can

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Antonio Gomes]

That can be done as soon as the client actually starts scrolling a given layer A.

All other layers cached, if any, can be dismissed at this point.

[Antonio Gomes]

Created attachment 160584 [details]
patch

[George Staikos]

Comment on attachment 160584 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160584&action=review

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:162
> +    while(it != end) {

missing space?

> Source/WebKit/blackberry/ChangeLog:13
> +        Patch providesa simple solution to that.

Missing space?

[Antonio Gomes]

Created attachment 160632 [details]
patch

(In reply to comment #2)
> (From update of attachment 160584 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160584&action=review
> 
> > Source/WebKit/blackberry/Api/InRegionScroller.cpp:162
> > +    while(it != end) {
> 
> missing space?
> 
> > Source/WebKit/blackberry/ChangeLog:13
> > +        Patch providesa simple solution to that.
> 
> Missing space?

Both fixed.

[Rob Buis]

Comment on attachment 160632 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160632&action=review

LGTM.

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:172
> +        // ::erase invalidades the iterators.

Typo: invalidates

> Source/WebKit/blackberry/ChangeLog:10
> +        of each layer, and on the diretion user swipes its finger.

Typo: direction

[Antonio Gomes]

https://trac.webkit.org/changeset/126767