Bug 94988 – webkit-patch is broken when I try to upload

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Simon Fraser (smfr)]

17$ $ wkpatch upload 90046
Total errors found: 0 in 47 files
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 59, in run
    self._ensure_bug_url(state)
  File "/Volumes/SSData/Development/OSX/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 52, in _ensure_bug_url
    if not changelog.latest_entry().bug_id():
AttributeError: 'NoneType' object has no attribute 'bug_id'

[Simon Fraser (smfr)]

wkpatch just expands to webkit-patch.

[Simon Fraser (smfr)]

Ugh, user error. I had cruft at the top of my Changelog.