Bug 94986 – Finally inlining should correctly track the catch context

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.  This will be a WIP for a few iterations.

[Filip Pizlo]

Created attachment 160528 [details]
work in progress

[Filip Pizlo]

Created attachment 160617 [details]
the patch

Still running tests to make sure I didn't break the world.

[WebKit Review Bot]

Attachment 160617 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:515:  The parameter name "tryData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 160617 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160617&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Finally inlining should correctly track the catch context

Missing comma after Finally.

[Filip Pizlo]

(In reply to comment #4)
> (From update of attachment 160617 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160617&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Finally inlining should correctly track the catch context
> 
> Missing comma after Finally.

Finally!  Finally inlining should correctly track the catch context.

[WebKit Review Bot]

Comment on attachment 160617 [details]
the patch

Attachment 160617 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13599879

New failing tests:
fast/js/throw-from-finally.html

[WebKit Review Bot]

Created attachment 160618 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Filip Pizlo]

(In reply to comment #7)
> Created an attachment (id=160618) [details]
> Archive of layout-test-results from gce-cr-linux-05
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Looks like I need to tweak the test to ensure that shouldBe() knows that what I'm interested in is comparing the stringified form of the expression.  I'll land after I fix that.

Other than that, it appears that this change passes all tests.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/126718