Bug 94983 – [Chromium] Stop texture updates when context is lost.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Reveman]

Stop texture uploads when context is lost rather than relying on the throttled texture uploader to still make progress with a lost context.

[David Reveman]

Created attachment 160525 [details]
Patch

Work in progress. Needs a unit test.

[Antoine Labour]

Comment on attachment 160525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160525&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:-623
> -    ASSERT(!m_currentTextureUpdateControllerOnImplThread->hasMoreUpdates());

Maybe you can replace those 2 with ASSERT(!hasMoreResourceUpdates()) which should work with either case?

[David Reveman]

Created attachment 160616 [details]
Patch

Add unit test and ASSERT

[James Robinson]

Comment on attachment 160616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160616&action=review

> Source/WebKit/chromium/ChangeLog:10
> +        (WTF::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create):

the anonymous namespace for tests confuses the ChangeLog script - could you delete the WTF::s before landing?

[David Reveman]

Created attachment 160760 [details]
Patch

Remove WTF::

[WebKit Review Bot]

Comment on attachment 160760 [details]
Patch

Rejecting attachment 160760 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13639019

[David Reveman]

Created attachment 160819 [details]
Patch

fix changelog

[WebKit Review Bot]

Comment on attachment 160819 [details]
Patch

Clearing flags on attachment: 160819

Committed r126835: <http://trac.webkit.org/changeset/126835>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.