Bug 94967 – AX: Should be able to tab to focus a link in a canvas subtree

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Dominic Mazzoni]

You can tab to focus controls in a canvas subtree (since bug 87898 was fixed), and you can explicitly focus a link from JavaScript, but you can't tab to focus links.

This is an easy fix, HTMLAnchorElement is check hasNonEmptyBoundingBox in order to skip empty links, but links within a canvas subtree should just avoid this check.

[Dominic Mazzoni]

Created attachment 160476 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160476 [details]
Patch

Attachment 160476 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13595280

New failing tests:
fast/events/tab-focus-link-in-canvas.html

[WebKit Review Bot]

Created attachment 160490 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Dominic Mazzoni]

Created attachment 160503 [details]
Patch

[chris fleizach]

Comment on attachment 160503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160503&action=review

looks good

> Source/WebCore/ChangeLog:9
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

remove this oops line

[Dominic Mazzoni]

Created attachment 161012 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 161012 [details]
Patch for landing

Clearing flags on attachment: 161012

Committed r126908: <http://trac.webkit.org/changeset/126908>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.