RESOLVED FIXED 94962
Don't create a new ResourceRequest if delegate returns the same NSURLRequest we passed it 
https://bugs.webkit.org/show_bug.cgi?id=94962
Summary Don't create a new ResourceRequest if delegate returns the same NSURLRequest ...
Pratik Solanki
Reported 2012-08-24 11:32:28 PDT
WebFrameLoaderClient::dispatchWillSendRequest does if (implementations->willSendRequestFunc) request = (NSURLRequest *)CallResourceLoadDelegate(implementations->willSendRequestFunc, webView, @selector(webView:resource:willSendRequest:redirectResponse:fromDataS request in this case is a ResourceRequest& that is passed in. This means we always create a new ResourceRequest. This can be wasteful in cases where the client decides to return us the exact same NSURLRequest without modifying it.
Attachments
Patch (2.52 KB, patch)
2012-08-24 12:48 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2012-08-24 12:52 PDT, Pratik Solanki 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2012-08-24 11:37:32 PDT
<rdar://problem/12163053>
Pratik Solanki
Comment 2 2012-08-24 12:48:06 PDT
Created attachment 160480 [details] Patch
Pratik Solanki
Comment 3 2012-08-24 12:52:19 PDT
Created attachment 160482 [details] Patch
Geoffrey Garen
Comment 4 2012-08-24 14:48:33 PDT
Comment on attachment 160482 [details] Patch r=me!
Pratik Solanki
Comment 5 2012-08-24 20:42:33 PDT
Committed r126678: <http://trac.webkit.org/changeset/126678>
Benjamin Poulain
Comment 6 2012-08-25 00:10:07 PDT
That's great!
Note You need to log in before you can comment on or make changes to this bug.