RESOLVED FIXED94959
Web Inspector: NMI: Instrument WebCore part of the Image class hierarchy 
https://bugs.webkit.org/show_bug.cgi?id=94959
Summary Web Inspector: NMI: Instrument WebCore part of the Image class hierarchy
Ilya Tikhonovsky
Reported 2012-08-24 11:10:24 PDT
EOM
Attachments
Patch (17.84 KB, patch)
2012-08-24 11:16 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-08-24 11:16:08 PDT
Created attachment 160458 [details] Patch
Yury Semikhatsky
Comment 2 2012-08-28 05:56:48 PDT
Comment on attachment 160458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160458&action=review > Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:90 > + MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage); Id rather move this method and the one above to GeneratedImage.cpp and include the latter in the build. You can fix GeneratedImage.cpp in a separate patch. > Source/WebCore/platform/graphics/Image.cpp:203 > + MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage); Do we miss decodedSize() now?
Ilya Tikhonovsky
Comment 3 2012-08-28 06:18:21 PDT
Comment on attachment 160458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160458&action=review >> Source/WebCore/platform/graphics/Image.cpp:203 >> + MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage); > > Do we miss decodedSize() now? Actually decodedSize is a sum of cached frames sizes. I reported it via BitmapImage instrumentation.
Ilya Tikhonovsky
Comment 4 2012-08-28 06:20:36 PDT
(In reply to comment #2) > (From update of attachment 160458 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160458&action=review > > > Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:90 > > + MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage); > > Id rather move this method and the one above to GeneratedImage.cpp and include the latter in the build. You can fix GeneratedImage.cpp in a separate patch. Agree.
Ilya Tikhonovsky
Comment 5 2012-08-29 02:28:30 PDT
Committed r126974: <http://trac.webkit.org/changeset/126974>
Note You need to log in before you can comment on or make changes to this bug.