Bug 94959 - Web Inspector: NMI: Instrument WebCore part of the Image class hierarchy
Summary: Web Inspector: NMI: Instrument WebCore part of the Image class hierarchy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-24 11:10 PDT by Ilya Tikhonovsky
Modified: 2012-08-29 02:28 PDT (History)
13 users (show)

See Also:

Attachments
Patch (17.84 KB, patch)
2012-08-24 11:16 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-08-24 11:10:24 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-08-24 11:16:08 PDT 
Created attachment 160458 [details]
Patch
Comment 2 Yury Semikhatsky 2012-08-28 05:56:48 PDT 
Comment on attachment 160458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160458&action=review

> Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:90
> +    MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage);

Id rather move this method and the one above to GeneratedImage.cpp and include the latter in the build. You can fix GeneratedImage.cpp in a separate patch.

> Source/WebCore/platform/graphics/Image.cpp:203
> +    MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage);

Do we miss decodedSize() now?
Comment 3 Ilya Tikhonovsky 2012-08-28 06:18:21 PDT 
Comment on attachment 160458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160458&action=review

>> Source/WebCore/platform/graphics/Image.cpp:203
>> +    MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage);
> 
> Do we miss decodedSize() now?

Actually decodedSize is a sum of cached frames sizes. I reported it via BitmapImage instrumentation.
Comment 4 Ilya Tikhonovsky 2012-08-28 06:20:36 PDT 
(In reply to comment #2)
> (From update of attachment 160458 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160458&action=review
> 
> > Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:90
> > +    MemoryClassInfo info(memoryObjectInfo, this, MemoryInstrumentation::CachedResourceImage);
> 
> Id rather move this method and the one above to GeneratedImage.cpp and include the latter in the build. You can fix GeneratedImage.cpp in a separate patch.

Agree.
Comment 5 Ilya Tikhonovsky 2012-08-29 02:28:30 PDT 
Committed r126974: <http://trac.webkit.org/changeset/126974>