Bug 94956 – [chromium] gestureTapDown should not select a RenderView node as target.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[W. James MacLean]

[chromium] gestureTapDown should not select a RenderView node as target.

[W. James MacLean]

Created attachment 160453 [details]
Patch

Currently, if a gestureTapDown occurs outside any clickable node, and the document (RenderView) has click handlers installed, the entire RenderView gets highlighted, which is not desired. This patch prevents us from falling back to the RenderView as highlight target.

[WebKit Review Bot]

Comment on attachment 160453 [details]
Patch

Clearing flags on attachment: 160453

Committed r126608: <http://trac.webkit.org/changeset/126608>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[LFC]

How about the situation that some pages have a click listener installed on a very big container which could contain a lot of text and images? Will it show up the highlight on that container, too?

[W. James MacLean]

(In reply to comment #4)
> How about the situation that some pages have a click listener installed on a very big container which could contain a lot of text and images? Will it show up the highlight on that container, too?

We are working (in a separate bug) to minimize this best we can, although if a web page designer has a click listener on a large div (for example), then we think we should highlight it as it is a valid touch target. There's is no way we can figure out whether the touch listener does anything meaningful, so we will at some point have to rely on site architects not sticking listeners on things and then doing nothing with them.

[LFC]

(In reply to comment #5)
> (In reply to comment #4)
> > How about the situation that some pages have a click listener installed on a very big container which could contain a lot of text and images? Will it show up the highlight on that container, too?
> 
> We are working (in a separate bug) to minimize this best we can, although if a web page designer has a click listener on a large div (for example), then we think we should highlight it as it is a valid touch target. There's is no way we can figure out whether the touch listener does anything meaningful, so we will at some point have to rely on site architects not sticking listeners on things and then doing nothing with them.

I'm very interested in this topic, and also I have made some attempts to avoid highlighting on large area. I assume that in most cases containers with only pure texts or images inside (eg, no links, no other clickable nodes at all) can be chosen as highlight nodes. What's your suggestions? Or you may tell me which but you are working on?