Bug 94950 - Fix a crash in SourceBufferList.remove().
Summary: Fix a crash in SourceBufferList.remove().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aaron Colwell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-24 10:30 PDT by Aaron Colwell
Modified: 2012-08-30 09:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2012-08-24 10:40 PDT, Aaron Colwell 		no flags Details | Formatted Diff | Diff
Patch (5.11 KB, patch)
2012-08-30 09:04 PDT, Aaron Colwell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2012-08-24 10:30:46 PDT 
Fix a crash in SourceBufferList.remove().
Comment 1 Aaron Colwell 2012-08-24 10:40:36 PDT 
Created attachment 160448 [details]
Patch
Comment 2 Kentaro Hara 2012-08-24 17:43:17 PDT 
Could you add a test for your change?
Comment 3 Eric Seidel (no email) 2012-08-27 13:23:13 PDT 
Comment on attachment 160448 [details]
Patch

We'll need a test if possible.  (Or an explanation in the ChangeLog why testing is impossible/iimpractical.)
Comment 4 Aaron Colwell 2012-08-28 11:16:03 PDT 
Closing in favor of https://bugs.webkit.org/show_bug.cgi?id=95217 
Attempting to create a test for this bug exposed a larger problem with the code.
Comment 5 Aaron Colwell 2012-08-28 13:18:33 PDT 
Reopening. eric.carlson@ asked me to keep the fix for this separate from https://bugs.webkit.org/show_bug.cgi?id=95217
Comment 6 Aaron Colwell 2012-08-30 09:04:13 PDT 
Created attachment 161486 [details]
Patch
Comment 7 WebKit Review Bot 2012-08-30 09:51:55 PDT 
Comment on attachment 161486 [details]
Patch

Clearing flags on attachment: 161486

Committed r127153: <http://trac.webkit.org/changeset/127153>
Comment 8 WebKit Review Bot 2012-08-30 09:51:58 PDT 
All reviewed patches have been landed.  Closing bug.