Bug 94946 – [chromium] CCLayerTreeHostImpl::scrollBy always assumes screen space deltas

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Robert Kroeger]

CCLayerTreeHostImpl::scrollBy always assumes screen space deltas. CrOS and Windows send ScrollUpdate events with DIP (scaled by the deviceScaleFactor) deltas. Correct DIP scroll deltas to screen deltas. Note in passing: the deltas are already float valued so could be fractional.

[Robert Kroeger]

Created attachment 160441 [details]
Patch

[Dana Jansens]

Comment on attachment 160441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160441&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:959
> +    pendingDelta.scale(deviceScaleFactor());

nit: use m_deviceScaleFactor directly when it is available.

[Robert Kroeger]

Created attachment 160445 [details]
Patch

[Robert Kroeger]

(In reply to comment #2)
> (From update of attachment 160441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160441&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:959
> > +    pendingDelta.scale(deviceScaleFactor());
> 
> nit: use m_deviceScaleFactor directly when it is available.

done, second patch.

[WebKit Review Bot]

Comment on attachment 160445 [details]
Patch

Attachment 160445 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13604155

New failing tests:
fast/frames/cached-frame-counter.html

[WebKit Review Bot]

Created attachment 160452 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[James Robinson]

Comment on attachment 160445 [details]
Patch

That EWS failure looks unrelated. R=me

[Alexandre Elias]

Comment on attachment 160445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160445&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:957
> +    // FIXME: Make this configurable once Chrome Android supports non-unity

You can delete this comment.  We'll divide before sending in the browser process (which should work fine once it's in floats).

[Robert Kroeger]

(In reply to comment #8)
> (From update of attachment 160445 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160445&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:957
> > +    // FIXME: Make this configurable once Chrome Android supports non-unity
> 
> You can delete this comment.  We'll divide before sending in the browser process (which should work fine once it's in floats).

done, third patch.

[Robert Kroeger]

Created attachment 160464 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160464 [details]
Patch

Clearing flags on attachment: 160464

Committed r126615: <http://trac.webkit.org/changeset/126615>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.