Bug 94946 - [chromium] CCLayerTreeHostImpl::scrollBy always assumes screen space deltas
Summary: [chromium] CCLayerTreeHostImpl::scrollBy always assumes screen space deltas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-24 09:37 PDT by Robert Kroeger
Modified: 2012-08-24 12:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2012-08-24 10:01 PDT, Robert Kroeger
no flags Details | Formatted Diff | Diff
Patch (1.88 KB, patch)
2012-08-24 10:13 PDT, Robert Kroeger
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 (374.69 KB, application/zip)
2012-08-24 10:52 PDT, WebKit Review Bot
no flags Details
Patch (1.78 KB, patch)
2012-08-24 11:46 PDT, Robert Kroeger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-08-24 09:37:37 PDT
CCLayerTreeHostImpl::scrollBy always assumes screen space deltas. CrOS and Windows send ScrollUpdate events with DIP (scaled by the deviceScaleFactor) deltas. Correct DIP scroll deltas to screen deltas. Note in passing: the deltas are already float valued so could be fractional.
Comment 1 Robert Kroeger 2012-08-24 10:01:41 PDT
Created attachment 160441 [details]
Patch
Comment 2 Dana Jansens 2012-08-24 10:06:05 PDT
Comment on attachment 160441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160441&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:959
> +    pendingDelta.scale(deviceScaleFactor());

nit: use m_deviceScaleFactor directly when it is available.
Comment 3 Robert Kroeger 2012-08-24 10:13:02 PDT
Created attachment 160445 [details]
Patch
Comment 4 Robert Kroeger 2012-08-24 10:13:29 PDT
(In reply to comment #2)
> (From update of attachment 160441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160441&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:959
> > +    pendingDelta.scale(deviceScaleFactor());
> 
> nit: use m_deviceScaleFactor directly when it is available.

done, second patch.
Comment 5 WebKit Review Bot 2012-08-24 10:52:53 PDT
Comment on attachment 160445 [details]
Patch

Attachment 160445 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13604155

New failing tests:
fast/frames/cached-frame-counter.html
Comment 6 WebKit Review Bot 2012-08-24 10:52:55 PDT
Created attachment 160452 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 7 James Robinson 2012-08-24 11:00:40 PDT
Comment on attachment 160445 [details]
Patch

That EWS failure looks unrelated. R=me
Comment 8 Alexandre Elias 2012-08-24 11:13:14 PDT
Comment on attachment 160445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160445&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:957
> +    // FIXME: Make this configurable once Chrome Android supports non-unity

You can delete this comment.  We'll divide before sending in the browser process (which should work fine once it's in floats).
Comment 9 Robert Kroeger 2012-08-24 11:43:56 PDT
(In reply to comment #8)
> (From update of attachment 160445 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160445&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:957
> > +    // FIXME: Make this configurable once Chrome Android supports non-unity
> 
> You can delete this comment.  We'll divide before sending in the browser process (which should work fine once it's in floats).

done, third patch.
Comment 10 Robert Kroeger 2012-08-24 11:46:52 PDT
Created attachment 160464 [details]
Patch
Comment 11 WebKit Review Bot 2012-08-24 12:54:49 PDT
Comment on attachment 160464 [details]
Patch

Clearing flags on attachment: 160464

Committed r126615: <http://trac.webkit.org/changeset/126615>
Comment 12 WebKit Review Bot 2012-08-24 12:54:54 PDT
All reviewed patches have been landed.  Closing bug.