Bug 94945 – [New Multicolumn] Plumbing to prepare for painting and hit testing implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Plumbing to prepare for painting and hit testing implementation.

[Dave Hyatt]

Created attachment 160438 [details]
Patch

[WebKit Review Bot]

Attachment 160438 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderRegion.h:101:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/rendering/RenderMultiColumnFlowThread.h:42:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/rendering/RenderRegionSet.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 160438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160438&action=review

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:172
> -    if (!columnCount())
> +    unsigned colCount = columnCount();
> +    if (!colCount)

?

[Peter Beverloo (cr-android ews)]

Comment on attachment 160438 [details]
Patch

Attachment 160438 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13600200

[Build Bot]

Comment on attachment 160438 [details]
Patch

Attachment 160438 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13600201

[Dave Hyatt]

Fixed in r126602.