Bug 94940 - Web Inspector: make ConsoleView listen to the JavaScriptContextManager
Summary: Web Inspector: make ConsoleView listen to the JavaScriptContextManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-24 08:42 PDT by Pavel Feldman
Modified: 2012-08-26 11:42 PDT (History)
10 users (show)

See Also:

Attachments
Patch (11.99 KB, patch)
2012-08-24 09:00 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (12.98 KB, patch)
2012-08-24 09:02 PDT, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-24 08:42:01 PDT 
Otherwise, model element is pushing data into the UI.
Comment 1 Pavel Feldman 2012-08-24 09:00:05 PDT 
Created attachment 160434 [details]
Patch
Comment 2 Pavel Feldman 2012-08-24 09:02:14 PDT 
Created attachment 160435 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-08-25 01:50:04 PDT 
Comment on attachment 160435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160435&action=review

> Source/WebCore/inspector/front-end/JavaScriptContextManager.js:56
> +        var result = [];

We now have Object.values(this._frameIdToContext)

> Source/WebCore/inspector/front-end/ParsedURL.js:-101
> -        if (trimmedHref.startsWith("data:") || trimmedHref.startsWith("blob:"))

Please mention this drive by in the changelog.
Comment 4 Pavel Feldman 2012-08-26 11:42:33 PDT 
Committed r126709: <http://trac.webkit.org/changeset/126709>