Bug 94933 – Web Inspector: [WebGL] Implement serializing WebGL state and replaying it later

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Adaikin]

Patch to follow.

[Andrey Adaikin]

Created attachment 160417 [details]
Patch

[Pavel Feldman]

Comment on attachment 160417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160417&action=review

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:257
> +        var thisObject = /** @type {ReplayableResource} */ (Resource.toReplayable(this._thisObject, cache));

No need for ( ) in case of assignment cast.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:678
> +    /** @inheritDoc */

We don't use @inheritDoc

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:782
> +            switch (uniform.type) {

You could use a map here.

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:783
> +                case gl.FLOAT:

Do not indent case

> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:979
> +    "ACTIVE_TEXTURE",

We need to add a test so that we could track changes to this set.

[Andrey Adaikin]

Comment on attachment 160417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160417&action=review

>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:257
>> +        var thisObject = /** @type {ReplayableResource} */ (Resource.toReplayable(this._thisObject, cache));
> 
> No need for ( ) in case of assignment cast.

you're right. done.

>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:678
>> +    /** @inheritDoc */
> 
> We don't use @inheritDoc

done.

>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:782
>> +            switch (uniform.type) {
> 
> You could use a map here.

done.

>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:783
>> +                case gl.FLOAT:
> 
> Do not indent case

done.

>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:979
>> +    "ACTIVE_TEXTURE",
> 
> We need to add a test so that we could track changes to this set.

Filed https://bugs.webkit.org/show_bug.cgi?id=94941

[Andrey Adaikin]

Created attachment 160427 [details]
Patch to land

[Andrey Adaikin]

Created attachment 160430 [details]
Patch to land

[Andrey Kosyakov]

Committed r126747: <http://trac.webkit.org/changeset/126747>