WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94933
Web Inspector: [WebGL] Implement serializing WebGL state and replaying it later
https://bugs.webkit.org/show_bug.cgi?id=94933
Summary
Web Inspector: [WebGL] Implement serializing WebGL state and replaying it later
Andrey Adaikin
Reported
2012-08-24 06:46:33 PDT
Patch to follow.
Attachments
Patch
(27.08 KB, patch)
2012-08-24 07:12 PDT
,
Andrey Adaikin
pfeldman
: review+
Details
Formatted Diff
Diff
Patch to land
(32.04 KB, patch)
2012-08-24 08:47 PDT
,
Andrey Adaikin
no flags
Details
Formatted Diff
Diff
Patch to land
(32.06 KB, patch)
2012-08-24 08:57 PDT
,
Andrey Adaikin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Andrey Adaikin
Comment 1
2012-08-24 07:12:59 PDT
Created
attachment 160417
[details]
Patch
Pavel Feldman
Comment 2
2012-08-24 08:15:13 PDT
Comment on
attachment 160417
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=160417&action=review
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:257 > + var thisObject = /** @type {ReplayableResource} */ (Resource.toReplayable(this._thisObject, cache));
No need for ( ) in case of assignment cast.
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:678 > + /** @inheritDoc */
We don't use @inheritDoc
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:782 > + switch (uniform.type) {
You could use a map here.
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:783 > + case gl.FLOAT:
Do not indent case
> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:979 > + "ACTIVE_TEXTURE",
We need to add a test so that we could track changes to this set.
Andrey Adaikin
Comment 3
2012-08-24 08:45:55 PDT
Comment on
attachment 160417
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=160417&action=review
>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:257 >> + var thisObject = /** @type {ReplayableResource} */ (Resource.toReplayable(this._thisObject, cache)); > > No need for ( ) in case of assignment cast.
you're right. done.
>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:678 >> + /** @inheritDoc */ > > We don't use @inheritDoc
done.
>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:782 >> + switch (uniform.type) { > > You could use a map here.
done.
>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:783 >> + case gl.FLOAT: > > Do not indent case
done.
>> Source/WebCore/inspector/InjectedScriptWebGLModuleSource.js:979 >> + "ACTIVE_TEXTURE", > > We need to add a test so that we could track changes to this set.
Filed
https://bugs.webkit.org/show_bug.cgi?id=94941
Andrey Adaikin
Comment 4
2012-08-24 08:47:18 PDT
Created
attachment 160427
[details]
Patch to land
Andrey Adaikin
Comment 5
2012-08-24 08:57:22 PDT
Created
attachment 160430
[details]
Patch to land
Andrey Kosyakov
Comment 6
2012-08-27 04:38:38 PDT
Committed
r126747
: <
http://trac.webkit.org/changeset/126747
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug