Bug 94905 - ShadowHost should be reattached during recalcStyle.
Summary: ShadowHost should be reattached during recalcStyle.
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Web Components Team
URL:
Keywords:
Depends on:
Blocks: 72352
  Show dependency treegraph
 
Reported: 2012-08-23 23:19 PDT by Takashi Sakamoto
Modified: 2019-10-04 22:11 PDT (History)
3 users (show)

See Also:


Attachments
repro (466 bytes, text/html)
2012-08-23 23:19 PDT, Takashi Sakamoto
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sakamoto 2012-08-23 23:19:14 PDT
Created attachment 160338 [details]
repro

When new shadow roots are added to the shadow host or content distribution is changed, the shadow host is reattached (detached and lazyAttached).
However, the detach clear the shadow host's style (the style is set to be null). The detach is invoked not during recalcStyle.

So suppose that adding a shadow root and applying css transition to the shadow host in the same time.
Since the shadow host's style is reset, no css transition can be started. This looks not good.

 So it might be better to set some flag here and to recreate a renderer during in Element::recalcStyle (i.e. during recalcStyle).
Comment 1 Dominic Cooney 2012-12-10 21:39:53 PST
The spec is not clear whether CSS transitions should be applied in this case.
Comment 2 Ryosuke Niwa 2019-10-04 22:11:35 PDT
We don't do this anymore.