Bug 94904 - Web Inspector: move ResourceViews to "components" module - it is used from the Resources as well.
Summary: Web Inspector: move ResourceViews to "components" module - it is used from th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on: 94911
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-23 23:15 PDT by Pavel Feldman
Modified: 2012-08-24 02:23 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.75 KB, patch)
2012-08-23 23:22 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-23 23:15:16 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2012-08-23 23:22:06 PDT 
Created attachment 160339 [details]
Patch
Comment 2 Pavel Feldman 2012-08-23 23:26:21 PDT 
Committed r126546: <http://trac.webkit.org/changeset/126546>
Comment 3 WebKit Review Bot 2012-08-24 00:52:14 PDT 
Re-opened since this is blocked by 94911
Comment 4 Csaba Osztrogonác 2012-08-24 01:22:00 PDT 
(In reply to comment #3)
> Re-opened since this is blocked by 94911

It was rolled out by http://trac.webkit.org/changeset/126546 .
Additionally it broke 2 tests on Qt and on Mac:

--- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/network-sidebar-width-expected.txt
+++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/network-sidebar-width-actual.txt
@@ -4,4 +4,5 @@
 Bug 65256
 Sidebar width: 200
 Sidebar width: 242
+Uncaught exception in inspector front-end: TypeError: 'undefined' is not a function (evaluating 'this.canEditSource()') [file:///Volumes/Data/slave/lion-debug-tests-wk1/build/WebKitBuild/Debug/WebCore.framework/Resources/inspector/SourceFrame.js:59]
 

http/tests/inspector/resource-tree/resource-tree-reload.html:
+Uncaught exception in inspector front-end: TypeError: 'undefined' is not a function [qrc:/webkit/inspector/SourceFrame.js:59]
Comment 5 Pavel Feldman 2012-08-24 02:23:12 PDT 
Committed r126563: <http://trac.webkit.org/changeset/126563>