Bug 94897 – Don't use malloc / destructors for activation objects

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Don't use malloc / destructors for activation objects

[Geoffrey Garen]

Created attachment 160554 [details]
Patch

[Oliver Hunt]

Comment on attachment 160554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160554&action=review

r+ if you can answer/correct the commented code

> Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp:45
> -    visitor.append(&thisObject->m_registerStore);
> +    if (thisObject->m_registerStore)
> +        visitor.append(&thisObject->m_registerStore);

you don't need this change

> Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:45
> +    JSNonFinalObject::visitChildren(thisObject, visitor);

Should be Base::visitChildren unless you have a compelling reason not to

> Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:46
> +    if (thisObject->m_symbolTable)

null check is unnecessary here

> Source/JavaScriptCore/runtime/SymbolTable.cpp:47
> +    SharedSymbolTable* thisObject = static_cast<SharedSymbolTable*>(cell);

jsCast<>

[Early Warning System Bot]

Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13591517

[Early Warning System Bot]

Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13600387

[Gyuyoung Kim]

Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13604347

[Build Bot]

Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13601446

[Geoffrey Garen]

Committed r126695: <http://trac.webkit.org/changeset/126695>