Bug 94897 - Don't use malloc / destructors for activation objects
Summary: Don't use malloc / destructors for activation objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 22:06 PDT by Geoffrey Garen
Modified: 2012-08-25 20:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (59.11 KB, patch)
2012-08-24 23:12 PDT, Geoffrey Garen 		oliver: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-08-23 22:06:58 PDT 
Don't use malloc / destructors for activation objects
Comment 1 Geoffrey Garen 2012-08-24 23:12:26 PDT 
Created attachment 160554 [details]
Patch
Comment 2 Oliver Hunt 2012-08-24 23:31:23 PDT 
Comment on attachment 160554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160554&action=review

r+ if you can answer/correct the commented code

> Source/JavaScriptCore/runtime/JSStaticScopeObject.cpp:45
> -    visitor.append(&thisObject->m_registerStore);
> +    if (thisObject->m_registerStore)
> +        visitor.append(&thisObject->m_registerStore);

you don't need this change

> Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:45
> +    JSNonFinalObject::visitChildren(thisObject, visitor);

Should be Base::visitChildren unless you have a compelling reason not to

> Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp:46
> +    if (thisObject->m_symbolTable)

null check is unnecessary here

> Source/JavaScriptCore/runtime/SymbolTable.cpp:47
> +    SharedSymbolTable* thisObject = static_cast<SharedSymbolTable*>(cell);

jsCast<>
Comment 3 Early Warning System Bot 2012-08-24 23:35:20 PDT 
Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13591517
Comment 4 Early Warning System Bot 2012-08-24 23:37:15 PDT 
Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13600387
Comment 5 Gyuyoung Kim 2012-08-24 23:37:17 PDT 
Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13604347
Comment 6 Build Bot 2012-08-25 07:37:59 PDT 
Comment on attachment 160554 [details]
Patch

Attachment 160554 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13601446
Comment 7 Geoffrey Garen 2012-08-25 20:24:59 PDT 
Committed r126695: <http://trac.webkit.org/changeset/126695>