Bug 94892 – [chromium] Fix lost context when textures are evicted

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Labour]

[chromium] Fix lost context when textures are evicted

[Antoine Labour]

Created attachment 160313 [details]
Patch

[James Robinson]

Comment on attachment 160313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160313&action=review

R=me. I wish this didn't keep breaking :/

> Source/WebCore/ChangeLog:3
> +        [chromium] Fix lost context when textures are evicted

ambitious title :)

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:33
> +#include "CCSingleThreadProxy.h"

hmm, need this just for DebugScoped...? we don't do a good job of putting utility things in good headers - I should go move some of these out into better places

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:2651
> +    virtual void didCommitAndDrawFrame()

OVERRIDE on this and the others please (got bit today trying to refactor some tests :/)

[Antoine Labour]

Created attachment 160315 [details]
Patch

[Antoine Labour]

(In reply to comment #2)
> (From update of attachment 160313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160313&action=review
> 
> R=me. I wish this didn't keep breaking :/
> 
> > Source/WebCore/ChangeLog:3
> > +        [chromium] Fix lost context when textures are evicted
> 
> ambitious title :)
> 
> > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:33
> > +#include "CCSingleThreadProxy.h"
> 
> hmm, need this just for DebugScoped...? we don't do a good job of putting utility things in good headers - I should go move some of these out into better places
> 
> > Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:2651
> > +    virtual void didCommitAndDrawFrame()
> 
> OVERRIDE on this and the others please (got bit today trying to refactor some tests :/)

Done.

I didn't do big refactorings here, because I think I'd like to merge this. I have a follow up that adds OVERRIDEs everywhere in this file.

[Antoine Labour]

Created attachment 160316 [details]
Patch for landing

[Antoine Labour]

Created attachment 160317 [details]
Patch for landing

[Antoine Labour]

(In reply to comment #4)
> I have a follow up that adds OVERRIDEs everywhere in this file.

https://bugs.webkit.org/show_bug.cgi?id=94894

[WebKit Review Bot]

Comment on attachment 160317 [details]
Patch for landing

Clearing flags on attachment: 160317

Committed r126540: <http://trac.webkit.org/changeset/126540>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.