Bug 94890 - REGRESSION(r126132): thumb doesn't match click position for rtl input type=range
Summary: REGRESSION(r126132): thumb doesn't match click position for rtl input type=range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 19:27 PDT by Keishi Hattori
Modified: 2012-08-23 21:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.76 KB, patch)
2012-08-23 20:48 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (7.51 KB, patch)
2012-08-23 21:04 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-08-23 19:27:53 PDT 
r126132 broke it
Comment 1 Keishi Hattori 2012-08-23 20:48:04 PDT 
Created attachment 160314 [details]
Patch
Comment 2 Kent Tamura 2012-08-23 20:55:28 PDT 
Comment on attachment 160314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160314&action=review

> Source/WebCore/ChangeLog:3
> +        thumb doesn't match click position for rtl input type=range

Please follow our notation for a regression bug. 
REGRESSION(revision): description

> Source/WebCore/html/shadow/SliderThumbElement.cpp:279
> +        if (!renderBox()->style()->isLeftToRightDirection())

"renderBox()->style()->isLeftToRightDirection()" appears three times in this function. We had better holding it in a local variable.
Comment 3 Keishi Hattori 2012-08-23 21:04:53 PDT 
Created attachment 160320 [details]
Patch
Comment 4 Kent Tamura 2012-08-23 21:09:43 PDT 
Comment on attachment 160320 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-08-23 21:55:15 PDT 
Comment on attachment 160320 [details]
Patch

Clearing flags on attachment: 160320

Committed r126539: <http://trac.webkit.org/changeset/126539>
Comment 6 WebKit Review Bot 2012-08-23 21:55:18 PDT 
All reviewed patches have been landed.  Closing bug.