Bug 94884 - [Chromium-Android] Upstream layout test expectations (Part 1)
Summary: [Chromium-Android] Upstream layout test expectations (Part 1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on: 94970
Blocks: 93627
  Show dependency treegraph
 
Reported: 2012-08-23 17:52 PDT by Xianzhu Wang
Modified: 2012-08-24 15:05 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.94 KB, patch)
2012-08-23 17:57 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff
rebased (10.83 KB, patch)
2012-08-24 11:08 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff
Patch (10.94 KB, patch)
2012-08-24 13:49 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-08-23 17:52:40 PDT
This part include:
- Removed ANDROID tag for passing tests and tests that should be covered by other Android specific rules
- Added android rules for fast/js and jquery/ tests
- crbug.com/144536
- Several other rules with public bugs
Comment 1 Xianzhu Wang 2012-08-23 17:57:32 PDT
Created attachment 160300 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-24 10:59:27 PDT
Comment on attachment 160300 [details]
Patch

Rejecting attachment 160300 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
th fuzz 3.
patching file LayoutTests/platform/chromium/TestExpectations
Hunk #11 succeeded at 3141 (offset 1 line).
Hunk #12 succeeded at 3277 (offset -1 lines).
Hunk #13 succeeded at 3511 (offset -1 lines).
Hunk #14 FAILED at 3526.
1 out of 14 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13599182
Comment 3 Xianzhu Wang 2012-08-24 11:08:29 PDT
Created attachment 160456 [details]
rebased
Comment 4 WebKit Review Bot 2012-08-24 11:50:45 PDT
Comment on attachment 160456 [details]
rebased

Clearing flags on attachment: 160456

Committed r126606: <http://trac.webkit.org/changeset/126606>
Comment 5 WebKit Review Bot 2012-08-24 11:50:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-08-24 13:17:05 PDT
Re-opened since this is blocked by 94970
Comment 7 Julien Chaffraix 2012-08-24 13:20:47 PDT
The patch that landed is causing linting errors on all the bots:

LayoutTests/platform/chromium/TestExpectations:79 Missing expectations BUGWK93631 SLOW ANDROID DEBUG : fast/js/toInt32UInt32.html
LayoutTests/platform/chromium/TestExpectations:2004 More specific entry for perf/show-hide-table-rows.html on line LayoutTests/platform/chromium/TestExpectations:2004 overrides line LayoutTests/platform/chromium/TestExpectations:2003. perf/show-hide-table-rows.html
LayoutTests/platform/chromium/TestExpectations:3497 More specific entry for fast/js/create-lots-of-workers.html on line LayoutTests/platform/chromium/TestExpectations:3497 overrides line LayoutTests/platform/chromium/TestExpectations:76. fast/js/create-lots-of-workers.html
LayoutTests/platform/chromium/TestExpectations:3498 More specific entry for fast/js/create-lots-of-workers.html on line LayoutTests/platform/chromium/TestExpectations:3498 overrides line LayoutTests/platform/chromium/TestExpectations:76. fast/js/create-lots-of-workers.html
Comment 8 Xianzhu Wang 2012-08-24 13:49:09 PDT
Created attachment 160497 [details]
Patch
Comment 9 WebKit Review Bot 2012-08-24 15:05:22 PDT
Comment on attachment 160497 [details]
Patch

Clearing flags on attachment: 160497

Committed r126628: <http://trac.webkit.org/changeset/126628>
Comment 10 WebKit Review Bot 2012-08-24 15:05:26 PDT
All reviewed patches have been landed.  Closing bug.