Bug 94883 - Remove RenderTableSection::removeChild
Summary: Remove RenderTableSection::removeChild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 94843
  Show dependency tree / graph
 
Reported: 2012-08-23 17:51 PDT by Julien Chaffraix
Modified: 2012-08-24 09:37 PDT (History)
4 users (show)

See Also:

Attachments
Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child. (5.57 KB, patch)
2012-08-23 18:21 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-08-23 17:51:21 PDT 
Table section post-child-removal invalidations all go through RenderTableSection::removeChild. Unfortunately we cannot guarantee that it will be called when moving children around (f.e. table splitting logic).

Since we introduced willBeRemovedFromTree, we can remove the function and do only the needed invalidation in the children's.

Patch forthcoming.
Comment 1 Julien Chaffraix 2012-08-23 18:21:32 PDT 
Created attachment 160304 [details]
Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child.
Comment 2 WebKit Review Bot 2012-08-24 09:37:32 PDT 
Comment on attachment 160304 [details]
Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child.

Clearing flags on attachment: 160304

Committed r126590: <http://trac.webkit.org/changeset/126590>
Comment 3 WebKit Review Bot 2012-08-24 09:37:35 PDT 
All reviewed patches have been landed.  Closing bug.