WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94883
Remove RenderTableSection::removeChild
https://bugs.webkit.org/show_bug.cgi?id=94883
Summary
Remove RenderTableSection::removeChild
Julien Chaffraix
Reported
2012-08-23 17:51:21 PDT
Table section post-child-removal invalidations all go through RenderTableSection::removeChild. Unfortunately we cannot guarantee that it will be called when moving children around (f.e. table splitting logic). Since we introduced willBeRemovedFromTree, we can remove the function and do only the needed invalidation in the children's. Patch forthcoming.
Attachments
Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child.
(5.57 KB, patch)
2012-08-23 18:21 PDT
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2012-08-23 18:21:32 PDT
Created
attachment 160304
[details]
Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child.
WebKit Review Bot
Comment 2
2012-08-24 09:37:32 PDT
Comment on
attachment 160304
[details]
Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child. Clearing flags on attachment: 160304 Committed
r126590
: <
http://trac.webkit.org/changeset/126590
>
WebKit Review Bot
Comment 3
2012-08-24 09:37:35 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug