Bug 9488 - Animated GIFs do not respect transforms in SVG
Summary: Animated GIFs do not respect transforms in SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-17 15:03 PDT by Eric Seidel (no email)
Modified: 2006-06-19 20:06 PDT (History)
0 users

See Also:

Attachments
Test case (with remote images) (940 bytes, image/svg+xml)
2006-06-17 15:03 PDT, Eric Seidel (no email) 		no flags Details
patch that fixes handling of partial repaints in SVG - many things were busted (11.16 KB, patch)
2006-06-18 01:19 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
better patch that fixes many more repaint issues. (19.53 KB, patch)
2006-06-18 20:04 PDT, Maciej Stachowiak 		no flags Details | Formatted Diff | Diff
even better patch (doesn't break opacity) plus some manual tests (55.39 KB, patch)
2006-06-19 01:53 PDT, Maciej Stachowiak 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-06-17 15:03:24 PDT 
Animated GIFs do not respect transforms in SVG

See example.
Comment 1 Eric Seidel (no email) 2006-06-17 15:03:54 PDT 
Created attachment 8890 [details]
Test case (with remote images)
Comment 2 Maciej Stachowiak 2006-06-18 01:19:43 PDT 
Created attachment 8898 [details]
patch that fixes handling of partial repaints in SVG - many things were busted
Comment 3 Darin Adler 2006-06-18 16:43:23 PDT 
Comment on attachment 8898 [details]
patch that fixes handling of partial repaints in SVG - many things were busted

looks good; r=me
Comment 4 Maciej Stachowiak 2006-06-18 20:04:58 PDT 
Created attachment 8916 [details]
better patch that fixes many more repaint issues.

This needs test cases landed with it. Maybe manual tests for now.
Comment 5 Maciej Stachowiak 2006-06-19 01:53:30 PDT 
Created attachment 8919 [details]
even better patch (doesn't break opacity) plus some manual tests

This breaks the metrics (but not rendering) on some svg layout tests, probably should not be landed until I investigate that. But might be worth preliminary review.
Comment 6 Maciej Stachowiak 2006-06-19 02:42:21 PDT 
On second thought... I think the metrics changes in the layout tests are all ok. They seem to more accurately represent the actual bounding boxes.
Comment 7 David Kilzer (:ddkilzer) 2006-06-19 20:06:34 PDT 
Committed as revision r14918.